Bugzilla – Attachment 169964 Details for
Bug 36879
Spurious warnings in QueryBuilder
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36879: Spurious warning in QueryBuilder
Bug-36879-Spurious-warning-in-QueryBuilder.patch (text/plain), 1.20 KB, created by
David Nind
on 2024-08-01 20:13:08 UTC
(
hide
)
Description:
Bug 36879: Spurious warning in QueryBuilder
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-08-01 20:13:08 UTC
Size:
1.20 KB
patch
obsolete
>From c62d9bac60ef1f26eba336d2a7d6276ddeb60a60 Mon Sep 17 00:00:00 2001 >From: Andreas Jonsson <andreas.jonsson@kreablo.se> >Date: Thu, 16 May 2024 09:38:09 +0200 >Subject: [PATCH] Bug 36879: Spurious warning in QueryBuilder > >Test plan: > >With ElasticSearch enabled, >* Perform a search using the default sort order > (i.e. 'relevance'). >* Verify that no warnings are generated in > plack-intranet-error.log > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >index dea84c83a2..cb69fd171a 100644 >--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >@@ -720,10 +720,11 @@ sub _convert_sort_fields { > # Convert the fields and orders, drop anything we don't know about. > grep { $_->{field} } map { > my ( $f, $d ) = /(.+)_(.+)/; >+ defined $f && defined $d ? > { > field => $sort_field_convert{$f}, > direction => $sort_order_convert{$d} >- } >+ } : { field => undef }; > } @sort_by; > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36879
:
166807
|
169964
|
169996