Attachment 169995 Details for Bug 37030 – Bug 37030: Use template wrapper for breadcrumbs: Cash register stats

[patch] Bug 37030: Use template wrapper for breadcrumbs: Cash register stats

Bug-37030-Use-template-wrapper-for-breadcrumbs-Cas.patch (text/plain), 2.62 KB, created by Marcel de Rooy on 2024-08-02 09:31:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-08-02 09:31:35 UTC

Size: 2.62 KB

patch

obsolete

>From a4fa7ff624559a8154dd4056f5c384876f31d483 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 4 Jun 2024 17:17:33 +0000
>Subject: [PATCH] Bug 37030: Use template wrapper for breadcrumbs: Cash
> register stats
>Content-Type: text/plain; charset=utf-8
>
>This patch updates the cash register statistics template so that they
>use the new WRAPPER for displaying breadcrumbs.
>
>To test, apply the patch and test page and its variations.
>Breadcrumbs should look correct, and each link should be correct.
>
>- Reports ->
>  - Cash register statistics
>    - Results
>
>Sponsored-By: Athens County Public Libraries
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../en/modules/reports/cash_register_stats.tt | 39 +++++++------------
> 1 file changed, 15 insertions(+), 24 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>index b1faf8f09a..0d6e646a3f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>@@ -26,35 +26,26 @@
>     [% INCLUDE 'cat-search.inc' %]
> [% END %]
> 
>+
> [% WRAPPER 'sub-header.inc' %]
>-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
>-    <ol>
>-        <li>
>-            <a href="/cgi-bin/koha/mainpage.pl">Home</a>
>-        </li>
>-        <li>
>+    [% WRAPPER breadcrumbs %]
>+        [% WRAPPER breadcrumb_item %]
>             <a href="/cgi-bin/koha/reports/reports-home.pl">Reports</a>
>-        </li>
>-
>+        [% END %]
>         [% IF ( do_it ) %]
>-            <li>
>+            [% WRAPPER breadcrumb_item %]
>                 <a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash register statistics</a>
>-            </li>
>-            <li>
>-                <a href="#" aria-current="page">
>-                    Results
>-                </a>
>-            </li>
>+            [% END %]
>+            [% WRAPPER breadcrumb_item bc_active= 1 %]
>+                <span>Results</span>
>+            [% END %]
>         [% ELSE %]
>-            <li>
>-                <a href="#" aria-current="page">
>-                    Cash register statistics
>-                </a>
>-            </li>
>-        [% END %]
>-    </ol>
>-</nav>
>-[% END %]
>+            [% WRAPPER breadcrumb_item bc_active= 1 %]
>+                <span>Cash register statistics</span>
>+            [% END %]
>+        [% END # /IF do_it %]
>+    [% END #/ WRAPPER breadcrumbs %]
>+[% END #/ WRAPPER sub-header.inc %]
> 
> <div class="main container-fluid">
>     <div class="row">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37030: 167411 | 167418 | 169995