Attachment 170009 Details for Bug 28122 – Bug 28122 - Remove old syslog config from SIPconfig.xml

[patch] Bug 28122 - Remove old syslog config from SIPconfig.xml

Bug-28122---Remove-old-syslog-config-from-SIPconfi.patch (text/plain), 2.62 KB, created by Kyle M Hall (khall) on 2024-08-02 16:08:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-08-02 16:08:03 UTC

Size: 2.62 KB

patch

obsolete

>From 2304da62d025ed0bb47b3fa65bcc2891f89521a6 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Fri, 2 Aug 2024 12:03:23 -0400
>Subject: [PATCH] Bug 28122 - Remove old syslog config from SIPconfig.xml
>
>Bug 15253 added logging based on log4perl for SIP2, replacing the
>old logging to syslog. It seems that the remnants of the old syslog
>config makes the SIP2 server not run properly.
>
>To reproduce:
>- Create a site called e.g. siptest:
>  $ sudo koha-create --create-db siptest
>- Verify that /etc/koha/sites/siptest/log4perl.conf has a section for
>  SIP:
>
>log4perl.logger.sip = DEBUG, SIP
>log4perl.appender.SIP=Log::Log4perl::Appender::File
>log4perl.appender.SIP.filename=/var/log/koha/siptest/sip.log
>log4perl.appender.SIP.mode=append
>log4perl.appender.SIP.layout=PatternLayout
>log4perl.appender.SIP.layout.ConversionPattern=[%d] [%p] %m %l %n
>log4perl.appender.SIP.utf8=1
>
>- Enable and start the SIP2 server:
>  $ sudo koha-sip --enable siptest
>  $ sudo koha-sip --start siptest
>- Use ps to check if the SIP server is actually running:
>  $ ps aux | grep SIPServer
>  If the output does not contain a line like this:
>  "perl /usr/share/koha/lib/C4/SIP/SIPServer.pm
>  /etc/koha/sites/siptest/SIPconfig.xml"
>  it means the actual SIP2 server is not running
>
>To test:
>- Apply this patch
>- If you are on a dev setup (e.g. kohadevbox), copy the log4perl
>  template to the standard location:
>  $ sudo cp kohaclone/debian/templates/log4perl-site.conf.in \
>  /etc/koha/log4perl-site.conf.in
>- Create another site and check the output from ps again. If it
>  contains one or more lines like "perl SIPServer.pm SIPconfig.xml"
>  that means the server is actually running
>
>You can also check if the server is running properly by talking to
>it over telnet: $ telnet localhost <port number from SIPconfig.xml>
>---
> debian/templates/SIPconfig.xml | 3 ---
> etc/SIPconfig.xml              | 3 ---
> 2 files changed, 6 deletions(-)
>
>diff --git a/debian/templates/SIPconfig.xml b/debian/templates/SIPconfig.xml
>index c9a1717794e..ba7b5e837ed 100644
>--- a/debian/templates/SIPconfig.xml
>+++ b/debian/templates/SIPconfig.xml
>@@ -10,9 +10,6 @@
>   <server-params
>     min_servers='1'
>     min_spare_servers='0'
>-    log_file='Sys::Syslog'
>-    syslog_ident='koha_sip'
>-    syslog_facility='local6'
>   />
> 
>   <listeners>
>diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml
>index 356175af123..33f1859c9f0 100644
>--- a/etc/SIPconfig.xml
>+++ b/etc/SIPconfig.xml
>@@ -15,9 +15,6 @@
>     min_servers='1'
>     min_spare_servers='0'
>     max_servers='1'
>-    log_file='Sys::Syslog'
>-    syslog_ident='koha_sip'
>-    syslog_facility='local6'
>     setsid="1"
>     user='koha'
>     group='koha'
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 28122: 119431 | 170008 | 170009 | 170010