Bugzilla – Attachment 170118 Details for
Bug 37586
Improve accessibility of top navigation in the OPAC with aria-labels
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37586: Added aria-labels to the masthead links.
Bug-37586-Added-aria-labels-to-the-masthead-links.patch (text/plain), 4.42 KB, created by
Laura Escamilla
on 2024-08-06 20:51:26 UTC
(
hide
)
Description:
Bug 37586: Added aria-labels to the masthead links.
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2024-08-06 20:51:26 UTC
Size:
4.42 KB
patch
obsolete
>From 8a0c2a7c65df30cd20be472ca6c578f751a4f4c6 Mon Sep 17 00:00:00 2001 >From: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Date: Tue, 6 Aug 2024 20:33:46 +0000 >Subject: [PATCH] Bug 37586: Added aria-labels to the masthead links. >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >1. **Check the OPAC Interface**: > - Open the OPAC in a normal-sized browser window. > - Youâll see the text next to the 'Cart' and 'Login' icons clearly. > - Gradually reduce the window size until the text next to these icons disappears. > - Inspect the icon elements. Youâll find that there is no alternative text (like `aria-label`) provided for these links. This lack of alternative text is an accessibility issue. > >2. **Apply the Patch**: > - Implement the provided patch to address the accessibility issue. > - Restart_all > >3. **Verify the Fix**: > - Inspect the icons again. > - For the 'Cart' icon, you should see an `aria-label` attribute with the text "View your shopping cart". > - For the 'Login' icon, you should see an `aria-label` attribute with the text "Log in to your account". > - These changes will improve accessibility for users relying on screen readers. > >4. **Sign Off**: > - Sign off and Have an amazing day! :D >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 21780d429b..f188ac692f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -37,7 +37,7 @@ > <ul id="cart-list-nav" class="navbar-nav"> > [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %] > <li class="nav-item js-show"> >- <a href="#" class="nav-link" title="Collect items you are interested in" id="cartmenulink" role="button"> >+ <a href="#" class="nav-link" title="Collect items you are interested in" id="cartmenulink" role="button" aria-label="View your shopping cart"> > <i id="carticon" class="fa fa-shopping-cart fa-icon-black" aria-hidden="true"></i> <span class="cartlabel">Cart</span> <span id="basketcount"></span> > </a> > </li> >@@ -114,11 +114,11 @@ > [% ELSE %] > [% IF Koha.Preference('casAuthentication') %] > [%# CAS authentication is too complicated for modal window %] >- <a class="nav-link login-link" href="/cgi-bin/koha/opac-user.pl"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> >+ <a class="nav-link login-link" href="/cgi-bin/koha/opac-user.pl" aria-label="Log in to your account"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> > [% ELSIF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %] >- <a href="/cgi-bin/koha/svc/auth/googleopenidconnect" class="nav-link login-link loginModal-trigger"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> >+ <a href="/cgi-bin/koha/svc/auth/googleopenidconnect" class="nav-link login-link loginModal-trigger" aria-label="Log in to your account"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> > [% ELSE %] >- <a href="/cgi-bin/koha/opac-user.pl" class="nav-link login-link loginModal-trigger"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> >+ <a href="/cgi-bin/koha/opac-user.pl" class="nav-link login-link loginModal-trigger" aria-label="Log in to your account"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> > [% END %] > [% END %] > [% END %] >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37586
:
170118
|
170134
|
170135
|
170472
|
170473
|
170530
|
170531