Bugzilla – Attachment 170158 Details for
Bug 32702
Item statuses that block holds should be checked in CanItemBeReserved
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32702: (follow-up) Add CanItemBeReserved checks to opac scripts
Bug-32702-follow-up-Add-CanItemBeReserved-checks-t.patch (text/plain), 2.38 KB, created by
Nick Clemens (kidclamp)
on 2024-08-08 11:22:58 UTC
(
hide
)
Description:
Bug 32702: (follow-up) Add CanItemBeReserved checks to opac scripts
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-08-08 11:22:58 UTC
Size:
2.38 KB
patch
obsolete
>From a8cdb8767e4164eb5e9e1c3448834f9f78bba92a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 8 Aug 2024 11:18:43 +0000 >Subject: [PATCH] Bug 32702: (follow-up) Add CanItemBeReserved checks to opac > scripts > >--- > opac/opac-ISBDdetail.pl | 4 +++- > opac/opac-MARCdetail.pl | 4 +++- > opac/opac-detail.pl | 6 ++++-- > 3 files changed, 10 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index a70d2ccf765..e1bda38016c 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -183,7 +183,9 @@ my $can_holds_be_placed = $patron ? 0 : $holdable_items; > if ($patron) { > my $items = $biblio->items; > while ( my $item = $items->next ) { >- $can_holds_be_placed = $can_holds_be_placed || IsAvailableForItemLevelRequest( $item, $patron, undef ); >+ $can_holds_be_placed = $can_holds_be_placed >+ || ( IsAvailableForItemLevelRequest( $item, $patron, undef ) >+ && CanItemBeReserved( $patron, $item, undef ) ); > } > } > >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index 406d2d4ceb1..5250621dff4 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -146,7 +146,9 @@ my $can_holds_be_placed = $patron ? 0 : $holdable_items; > if ($patron) { > $items->reset; > while ( my $item = $items->next ) { >- $can_holds_be_placed = $can_holds_be_placed || IsAvailableForItemLevelRequest( $item, $patron, undef ); >+ $can_holds_be_placed = $can_holds_be_placed >+ || ( IsAvailableForItemLevelRequest( $item, $patron, undef ) >+ && CanItemBeReserved( $patron, $item, undef ) ); > } > } > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 96c73dd1fc1..3463cf18f8b 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -694,8 +694,10 @@ else { > > # We only need to check if we haven't determined holds can be placed > # and if we don't have patron, we have already decided >- $can_holds_be_placed = >- $can_holds_be_placed || $patron && IsAvailableForItemLevelRequest( $item, $patron, undef ); >+ $can_holds_be_placed = $can_holds_be_placed >+ || ( $patron >+ && IsAvailableForItemLevelRequest( $item, $patron, undef ) >+ && CanItemBeReserved( $patron, $item, undef ) ); > > # get collection code description, too > my $ccode = $item->ccode; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32702
:
145590
|
149762
|
149763
|
157133
|
157134
|
161725
|
161726
|
170156
|
170157
| 170158