Bugzilla – Attachment 170165 Details for
Bug 37508
SQL reports should not show patron password hash if queried
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37508: (follow-up) Don't pass the column or sql containing password
Bug-37508-follow-up-Dont-pass-the-column-or-sql-co.patch (text/plain), 1.06 KB, created by
Aleisha Amohia
on 2024-08-08 23:54:44 UTC
(
hide
)
Description:
Bug 37508: (follow-up) Don't pass the column or sql containing password
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2024-08-08 23:54:44 UTC
Size:
1.06 KB
patch
obsolete
>From b48dea0c22934b694c0b4de898e58044159cd0a6 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleisha@catalyst.net.nz> >Date: Thu, 8 Aug 2024 23:53:47 +0000 >Subject: [PATCH] Bug 37508: (follow-up) Don't pass the column or sql > containing password > >This patch replaces these variables with a non-translatable message. >--- > C4/Reports/Guided.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 2bbccff3a33..481eb0962e2 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -625,12 +625,12 @@ sub execute_query { > return ( $sth, { queryerr => $sth->errstr } ) if ( $sth->err ); > > if ( $sql =~ m/password/ ) { >- return ( $sth, { passworderr => $sql } ); >+ return ( $sth, { passworderr => "Illegal column in SQL" } ); > } > > foreach my $column ( @{ $sth->{NAME_lc} } ) { > if ( $column eq 'password' ) { >- return ( $sth, { passworderr => $column } ); >+ return ( $sth, { passworderr => "Illegal column in results" } ); > } > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37508
:
169806
|
169810
|
170121
|
170124
|
170125
|
170126
|
170127
|
170165
|
170171
|
170172
|
170173
|
170174
|
170175
|
170176
|
170229
|
170230
|
170241
|
170242
|
170243
|
170244
|
170245
|
170246
|
170247
|
170253