Bugzilla – Attachment 170172 Details for
Bug 37508
SQL reports should not show patron password hash if queried
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37508: Test for errors when returning an aliased password column
Bug-37508-Test-for-errors-when-returning-an-aliase.patch (text/plain), 1.25 KB, created by
Marcel de Rooy
on 2024-08-09 10:09:45 UTC
(
hide
)
Description:
Bug 37508: Test for errors when returning an aliased password column
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-08-09 10:09:45 UTC
Size:
1.25 KB
patch
obsolete
>From f1cd412e6104f82a396b325f18e10cd9ab4173b6 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 7 Aug 2024 01:15:10 +0000 >Subject: [PATCH] Bug 37508: Test for errors when returning an aliased password > column >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Reports/Guided.t | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Reports/Guided.t b/t/db_dependent/Reports/Guided.t >index 0db1a6295b..18bd7763d2 100755 >--- a/t/db_dependent/Reports/Guided.t >+++ b/t/db_dependent/Reports/Guided.t >@@ -501,7 +501,7 @@ subtest 'nb_rows() tests' => sub { > > subtest 'Returning passwords tests' => sub { > >- plan tests => 3; >+ plan tests => 4; > > my $dbh = C4::Context->dbh; > $schema->storage->txn_begin; >@@ -524,6 +524,12 @@ subtest 'Returning passwords tests' => sub { > > is( defined($errors), 1, 'Query returns password field' ); > >+ $query = q{ SELECT password as secret FROM borrowers }; >+ >+ ( $sth, $errors ) = execute_query( { sql => $query } ); >+ >+ is( defined($errors), 1, 'Error raised for returning password' ); >+ > $schema->storage->txn_rollback; > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37508
:
169806
|
169810
|
170121
|
170124
|
170125
|
170126
|
170127
|
170165
|
170171
| 170172 |
170173
|
170174
|
170175
|
170176
|
170229
|
170230
|
170241
|
170242
|
170243
|
170244
|
170245
|
170246
|
170247
|
170253