Bugzilla – Attachment 170198 Details for
Bug 36789
Transform a booking into checkout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36789: (follow-up) rebase after using object directly in letter
Bug-36789-follow-up-rebase-after-using-object-dire.patch (text/plain), 2.27 KB, created by
Thibaud Guillot (thibaud_g)
on 2024-08-09 14:15:33 UTC
(
hide
)
Description:
Bug 36789: (follow-up) rebase after using object directly in letter
Filename:
MIME Type:
Creator:
Thibaud Guillot (thibaud_g)
Created:
2024-08-09 14:15:33 UTC
Size:
2.27 KB
patch
obsolete
>From 67491c6580aef937d3a79d8976edb981888bef02 Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot@biblibre.com> >Date: Fri, 9 Aug 2024 16:13:56 +0200 >Subject: [PATCH] Bug 36789: (follow-up) rebase after using object directly in > letter > >--- > Koha/Booking.pm | 37 +++++++++++++++++++------------------ > 1 file changed, 19 insertions(+), 18 deletions(-) > >diff --git a/Koha/Booking.pm b/Koha/Booking.pm >index 0331c1749e7..4c3bc5f1589 100644 >--- a/Koha/Booking.pm >+++ b/Koha/Booking.pm >@@ -251,29 +251,30 @@ sub to_api_mapping { > =cut > > sub delete { >- my ($self) = @_; >+ my ($self, $params) = @_; > > my $patron = $self->patron; > my $pickup_library = $self->pickup_library; > >- if ( not defined( $params->{'transform_to_checkout'} ) ) { >- my $letter = C4::Letters::GetPreparedLetter( >- module => 'bookings', >- letter_code => 'BOOKING_CANCELLATION', >- message_transport_type => 'email', >- branchcode => $pickup_library->branchcode, >- lang => $patron->lang, >- objects => { booking => $self, branch => $pickup_library } >- ); >- >- if ($letter) { >- C4::Letters::EnqueueLetter( >- { >- letter => $letter, >- borrowernumber => $patron->borrowernumber, >- message_transport_type => 'email', >- } >+ if ( not defined( $params->{'transform_to_checkout'} ) ) { >+ my $letter = C4::Letters::GetPreparedLetter( >+ module => 'bookings', >+ letter_code => 'BOOKING_CANCELLATION', >+ message_transport_type => 'email', >+ branchcode => $pickup_library->branchcode, >+ lang => $patron->lang, >+ objects => { booking => $self, branch => $pickup_library } > ); >+ >+ if ($letter) { >+ C4::Letters::EnqueueLetter( >+ { >+ letter => $letter, >+ borrowernumber => $patron->borrowernumber, >+ message_transport_type => 'email', >+ } >+ ); >+ } > } > > my $deleted = $self->SUPER::delete($self); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36789
:
166213
|
167191
|
167242
|
167246
|
167268
|
167307
|
167309
|
167311
|
167368
|
167369
|
167602
|
167906
|
167907
|
170198
|
171553
|
171554
|
171555
|
172058
|
172059
|
172060
|
176452
|
176453
|
176489