Bugzilla – Attachment 170199 Details for
Bug 37606
Framework export module should escape double quotes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37606 - Fix framework export module to replace double quotes with simple quotes
Bug-37606---Fix-framework-export-module-to-replace.patch (text/plain), 1.27 KB, created by
Baptiste Wojtkowski (bwoj)
on 2024-08-09 14:52:56 UTC
(
hide
)
Description:
Bug 37606 - Fix framework export module to replace double quotes with simple quotes
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2024-08-09 14:52:56 UTC
Size:
1.27 KB
patch
obsolete
>From f20f12209c8b31624c99fd22b471dbfefac20b72 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <bski@laposte.net> >Date: Fri, 9 Aug 2024 16:33:37 +0200 >Subject: [PATCH] Bug 37606 - Fix framework export module to replace double > quotes with simple quotes > >When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. > >TEST PLAN: >1 - Change a framework to add a field containing double quote in name >2 - Export it in csv >3 - Create a new framework >4 - Import the csv in the new framework -> every fields after the one >containing double quotes should have no subfields >5 - APPLY PATCH >6 - Repeat 2-5 -> everything should be correctly exported >--- > C4/ImportExportFramework.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm >index 3d44d46..f04f308 100644 >--- a/C4/ImportExportFramework.pm >+++ b/C4/ImportExportFramework.pm >@@ -291,6 +291,7 @@ sub _export_table_csv > for my $field (@fields) { > my $value = $hashRef->{$field} // q||; > $value =~ s/[\r\n]//g; >+ $value =~ s/"/'/g; > $$strCSV .= '"' . $value . '",'; > } > chop $$strCSV; >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37606
:
170199
|
170200
|
171343
|
171344
|
172934