Bugzilla – Attachment 170230 Details for
Bug 37508
SQL reports should not show patron password hash if queried
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37508: Don't return Internal server error when running report
Bug-37508-Dont-return-Internal-server-error-when-r.patch (text/plain), 1.18 KB, created by
Marcel de Rooy
on 2024-08-12 13:22:31 UTC
(
hide
)
Description:
Bug 37508: Don't return Internal server error when running report
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-08-12 13:22:31 UTC
Size:
1.18 KB
patch
obsolete
>From 859c7301d142243d931f8c5c7962a8fa0550d88c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 12 Aug 2024 12:10:12 +0000 >Subject: [PATCH] Bug 37508: Don't return Internal server error when running > report >Content-Type: text/plain; charset=utf-8 > >To test: >1 - Create a report like: >SELECT "a" >FROM borrowers >WHERE <<Test>> != '' >2 - Run report >3 - Enter "password" >4 - Internal server error / stacktrace >5 - Apply patch >6 - Repeat >7 - Get a yellow warning box > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reports/guided_reports.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index b7c722945a..b85b36a860 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -953,7 +953,7 @@ if ($op eq 'run'){ > ); > my $total; > if (!$sth) { >- die "execute_query failed to return sth for report $report_id: $sql"; >+ push @errors, "Report could not be run " . $errors; > } elsif ( !$errors ) { > $total = nb_rows($sql) || 0; > my $headers = header_cell_loop($sth); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37508
:
169806
|
169810
|
170121
|
170124
|
170125
|
170126
|
170127
|
170165
|
170171
|
170172
|
170173
|
170174
|
170175
|
170176
|
170229
| 170230 |
170241
|
170242
|
170243
|
170244
|
170245
|
170246
|
170247
|
170253