Bugzilla – Attachment 170234 Details for
Bug 34585
"When to charge" columns value not copied when editing circulation rule
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34585: Add data-code attribute to chargeperiod_charge_at selector
Bug-34585-Add-data-code-attribute-to-chargeperiodc.patch (text/plain), 2.55 KB, created by
Lucas Gass (lukeg)
on 2024-08-12 15:54:00 UTC
(
hide
)
Description:
Bug 34585: Add data-code attribute to chargeperiod_charge_at selector
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-08-12 15:54:00 UTC
Size:
2.55 KB
patch
obsolete
>From b912fd339469ce64a5eb632d45134f89fba27706 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Tue, 22 Aug 2023 13:45:27 +0300 >Subject: [PATCH] Bug 34585: Add data-code attribute to chargeperiod_charge_at > selector > >When one tries to edit circulation rule "When to charge" >columns value is always set as "End of interval". This patch adds >data-code attribute to chargeperiod_charge_at selector >to define existing rules value. > >To reproduce: >1. Navigate to Circulation and fine rules page. >2. Find or create a rule with a "When to charge" value set as >"Start of interval". >3. Edit rule. >=> Note that "When to charge" value is now "End of interval", >while as the other values should be copied as they were. >4. Apply this patch. >5. Edit rule again. >=> "When to charge" should now be copied correctly. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index f1193b1441..f4901df8d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -291,7 +291,13 @@ > <td>[% decreaseloanholds | html %]</td> > <td>[% fine | $Price %]</td> > <td>[% chargeperiod | html %]</td> >- <td>[% IF chargeperiod_charge_at %]Start of interval[% ELSE %]End of interval[% END %]</td> >+ <td data-code="[% chargeperiod_charge_at | html %]"> >+ [% IF chargeperiod_charge_at %] >+ Start of interval >+ [% ELSE %] >+ End of interval >+ [% END %] >+ </td> > <td>[% firstremind | html %]</td> > <td>[% IF overduefinescap %][% overduefinescap | $Price %][% ELSE %][% END %]</td> > <td> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34585
:
154688
|
160370
|
160488
|
170216
| 170234