Bugzilla – Attachment 170253 Details for
Bug 37508
SQL reports should not show patron password hash if queried
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[23.11.x] Bug 37508: (QA follow-up) Move sth error check up
2311x-Bug-37508-QA-follow-up-Move-sth-error-check-.patch (text/plain), 1.20 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-08-13 04:12:39 UTC
(
hide
)
Description:
[23.11.x] Bug 37508: (QA follow-up) Move sth error check up
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-08-13 04:12:39 UTC
Size:
1.20 KB
patch
obsolete
>From 262a410a937e26f6d728edab8d55a56054ab9cea Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 13 Aug 2024 01:08:44 -0300 >Subject: [PATCH] [23.11.x] Bug 37508: (QA follow-up) Move sth error check up > >This patch moves the error check right before the ->check_columns call. >This is how main and 24.05 behave. 23.11 doesn't have bug 35907 >backported so things are not exactly the same. With this patch tests >pass and the only difference in behavior is logging. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Reports/Guided.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index f52c6babe44..3004b63bc6b 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -615,11 +615,12 @@ sub execute_query { > }; > warn $@ if $@; > >+ return ( $sth, { queryerr => $sth->errstr } ) if ($sth->err); >+ > # Check if table.* contained forbidden column names > return ( $sth, { passworderr => "Illegal column in results" } ) > if Koha::Report->new->check_columns( undef, $sth->{NAME_lc} ); > >- return ( $sth, { queryerr => $sth->errstr } ) if ($sth->err); > return ( $sth ); > } > >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37508
:
169806
|
169810
|
170121
|
170124
|
170125
|
170126
|
170127
|
170165
|
170171
|
170172
|
170173
|
170174
|
170175
|
170176
|
170229
|
170230
|
170241
|
170242
|
170243
|
170244
|
170245
|
170246
|
170247
| 170253