Attachment 170294 Details for Bug 37591 – Bug 37591: fix moredetail.tt performance issue

[patch] Bug 37591: fix moredetail.tt performance issue

Bug-37591-fix-moredetailtt-performance-issue.patch (text/plain), 2.57 KB, created by Emily Lamancusa (emlam) on 2024-08-13 20:06:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-08-13 20:06:21 UTC

Size: 2.57 KB

patch

obsolete

>From 16a9ef06125f2d3dcda256dd08751bcf420e938b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Johanna=20R=C3=A4is=C3=A4?= <johanna.raisa@gmail.com>
>Date: Fri, 9 Aug 2024 08:58:31 +0300
>Subject: [PATCH] Bug 37591: fix moredetail.tt performance issue
>
>This patch fixes the performance issue in moredetail.tt by removing the
>unnecessary call of checkout_renewals table.
>
>To test:
>1. Create lot of checkouts and renewals for a record.
>2. Open the moredetail page for the record.
>3. Check the timing of the page load.
>4. Apply the patch and check the timing of the page load again.
>5. The page load should be faster after applying the patch.
>
>Sponsored-by: Koha-Suomi Oy
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt   | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>index 6ef020cecb..11878892eb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>@@ -193,11 +193,11 @@
>                                                 [% END %]
>                                             [% END %]
>                                         </li>
>-                                        [% IF ITEM_DAT.object.checkout.renewals.count && ITEM_DAT.object.checkout %]
>+                                        [% IF ITEM_DAT.object.checkout.renewals_count %]
>                                             <li>
>                                                 <span class="label">Current renewals:</span>
>-                                                [% ITEM_DAT.object.checkout.renewals.count | html %]
>-                                                    [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.object.checkout.renewals.count | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ]
>+                                                [% ITEM_DAT.object.checkout.renewals_count | html %]
>+                                                    [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.object.checkout.renewals_count | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ]
>                                             </li>
>                                         [% END %]
>                                         [% IF itemlostloop %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37591: 170168 | 170169 | 170240 | 170294