Bugzilla – Attachment 170379 Details for
Bug 37308
Add user-agent to SUSHI outgoing requests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37308: (QA follow-up) Tidy code
Bug-37308-QA-follow-up-Tidy-code.patch (text/plain), 2.35 KB, created by
Kyle M Hall (khall)
on 2024-08-15 12:41:35 UTC
(
hide
)
Description:
Bug 37308: (QA follow-up) Tidy code
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-08-15 12:41:35 UTC
Size:
2.35 KB
patch
obsolete
>From 5c6e53c5f90053a205d8969428361c532fa0f0a7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 14 Aug 2024 14:41:35 +0000 >Subject: [PATCH] Bug 37308: (QA follow-up) Tidy code > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/ERM/EUsage/UsageDataProvider.pm | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/Koha/ERM/EUsage/UsageDataProvider.pm b/Koha/ERM/EUsage/UsageDataProvider.pm >index 1f2f7de9a3d..e85ee58ce8c 100644 >--- a/Koha/ERM/EUsage/UsageDataProvider.pm >+++ b/Koha/ERM/EUsage/UsageDataProvider.pm >@@ -174,9 +174,9 @@ sub harvest_sushi { > $self->{report_type} = $args->{report_type}; > $self->{begin_date} = $args->{begin_date}; > $self->{end_date} = $args->{end_date}; >- my $url = $self->_build_url_query; >- my $request = HTTP::Request->new( 'GET' => $url ); >- my $ua = LWP::UserAgent->new; >+ my $url = $self->_build_url_query; >+ my $request = HTTP::Request->new( 'GET' => $url ); >+ my $ua = LWP::UserAgent->new; > $ua->agent( 'Koha/' . Koha::version() ); > my $response = $ua->simple_request($request); > >@@ -277,10 +277,10 @@ sub test_connection { > $url .= 'status'; > $url .= '?customer_id=' . $self->customer_id; > $url .= '&requestor_id=' . $self->requestor_id if $self->requestor_id; >- $url .= '&api_key=' . $self->api_key if $self->api_key; >+ $url .= '&api_key=' . $self->api_key if $self->api_key; > >- my $request = HTTP::Request->new( 'GET' => $url ); >- my $ua = LWP::UserAgent->new; >+ my $request = HTTP::Request->new( 'GET' => $url ); >+ my $ua = LWP::UserAgent->new; > $ua->agent( 'Koha/' . Koha::version() ); > my $response = $ua->simple_request($request); > >@@ -396,9 +396,9 @@ sub _build_url_query { > $url .= lc $self->{report_type}; > $url .= '?customer_id=' . $self->customer_id; > $url .= '&requestor_id=' . $self->requestor_id if $self->requestor_id; >- $url .= '&api_key=' . $self->api_key if $self->api_key; >+ $url .= '&api_key=' . $self->api_key if $self->api_key; > $url .= '&begin_date=' . substr $self->{begin_date}, 0, 7 if $self->{begin_date}; >- $url .= '&end_date=' . substr $self->{end_date}, 0, 7 if $self->{end_date}; >+ $url .= '&end_date=' . substr $self->{end_date}, 0, 7 if $self->{end_date}; > > return $url; > } >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37308
:
168746
|
168750
|
168751
|
170377
|
170378
| 170379