Attachment 170391 Details for Bug 36915 – Bug 36915: (QA follow-up) Passing less to encourage traversal

[patch] Bug 36915: (QA follow-up) Passing less to encourage traversal

Bug-36915-QA-follow-up-Passing-less-to-encourage-t.patch (text/plain), 1.74 KB, created by Martin Renvoize (ashimema) on 2024-08-15 14:37:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-08-15 14:37:28 UTC

Size: 1.74 KB

patch

obsolete

>From 86c57563ffcc9194ddf02b9b13c5e85b87c18605 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 15 Aug 2024 15:29:30 +0100
>Subject: [PATCH] Bug 36915: (QA follow-up) Passing less to encourage traversal
>
>I generally push for contextual use of accessors in TT notices and try
>to reduce extra lookups.
>
>In this case we can access the pickup library branchname directly using
>the pickup_library relation available to us in the booking object we
>pass.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Booking.pm                                      | 2 +-
> installer/data/mysql/en/mandatory/sample_notices.yml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Booking.pm b/Koha/Booking.pm
>index de230e07744..e5297d8d17b 100644
>--- a/Koha/Booking.pm
>+++ b/Koha/Booking.pm
>@@ -262,7 +262,7 @@ sub delete {
>         message_transport_type => 'email',
>         branchcode             => $pickup_library->branchcode,
>         lang                   => $patron->lang,
>-        objects                => { booking => $self, branch => $pickup_library }
>+        objects                => { booking => $self }
>     );
> 
>     if ($letter) {
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index b23f9db57e7..ec0e2386dab 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -64,7 +64,7 @@ tables:
>             - "<br>"
>             - "Kind regards<br>"
>             - "<br>"
>-            - "[% branch.branchname %]"
>+            - "[% booking.pickup_library.branchname %]"
> 
>         - module: catalogue
>           code: TICKET_ACKNOWLEDGE
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 36915: 167010 | 167013 | 168149 | 168150 | 168155 | 170058 | 170077 | 170078 | 170079 | 170080 | 170099 | 170155 | 170203 | 170204 | 170205 | 170206 | 170207 | 170208 | 170385 | 170386 | 170387 | 170388 | 170389 | 170390 | 170391