Attachment 170426 Details for Bug 37629 – Bug 37629: Link to news are broken

[patch] Bug 37629: Link to news are broken

Bug-37629-Link-to-news-are-broken.patch (text/plain), 1.89 KB, created by Marcel de Rooy on 2024-08-16 06:45:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-08-16 06:45:05 UTC

Size: 1.89 KB

patch

obsolete

>From 07203435c1cc456c3cad7fffe83876c76c096e97 Mon Sep 17 00:00:00 2001
>From: Baptiste Wojtkowski <bski@laposte.net>
>Date: Tue, 13 Aug 2024 16:39:04 +0200
>Subject: [PATCH] Bug 37629: Link to news are broken
>Content-Type: text/plain; charset=utf-8
>
>When browsing news in the opac (opac-main.pl), links in the titles of
>news are broken. The id pasted in the link is the id from the
>additional_contents_localizations instead of the id from
>additional_contents.
>
>TEST PLAN:
>1 - In intranet create a news with multiple languages
>2 - Create a second news
>3 - In OPAC, the link of the title of the second news (and maybe the
>    first) should be broken APPLY PATCH
>4 - In OPAC, the link of the title of both news should work
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>index 22a995b516..75182f9149 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>@@ -95,7 +95,7 @@
>                             [% IF ( news_item ) %]
>                                 [% koha_new.title | html %]
>                             [% ELSE %]
>-                                <a id="newsitem[% koha_new.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.id | uri %]">[% koha_new.title | html %]</a>
>+                                <a id="newsitem[% koha_new.additional_content.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.additional_content.id | uri %]">[% koha_new.title | html %]</a>
>                             [% END %]
>                         </h4>
>                         <div class="newsbody">[% koha_new.content | $raw %]</div>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37629: 170266 | 170318 | 170426