Attachment 170432 Details for Bug 37595 – Bug 37595: Double HTML escaped ampersand in pagination bar

[patch] Bug 37595: Double HTML escaped ampersand in pagination bar

Bug-37595-Double-HTML-escaped-ampersand-in-paginat.patch (text/plain), 2.31 KB, created by Marcel de Rooy on 2024-08-16 07:27:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-08-16 07:27:36 UTC

Size: 2.31 KB

patch

obsolete

>From a7eee1ec252c8812d2e3eb4e802d94b4fda33cb3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 8 Aug 2024 17:54:48 +0000
>Subject: [PATCH] Bug 37595: Double HTML escaped ampersand in pagination bar
>Content-Type: text/plain; charset=utf-8
>
>This patch removes escaping of ampersands in the part of
>guided_reports.pl that builds information for the pagination routine.
>The information is going to be escaped in a later step.
>
>To test, apply the patch and go to Reports.
>
>- If necessary, create a report which will return more than 20 results.
>- Run the report. You should see a pagination bar at the top of the
>  table of results.
>- View the page source and look for the markup for the pagination menu.
>  Searching for 'rel="start"' works well.
>- Confirm that you see '&amp;' between the link parameters instead of
>  '&amp;amp;', e.g.
>
>  guided_reports.pl?id=347&amp;op=run&amp;limit=20&amp;want_full_chart=0&amp;page=1
>
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> reports/guided_reports.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index b7c722945a..7ce0417340 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -971,12 +971,12 @@ if ($op eq 'run'){
>                 }
> 
>                 my $totpages = int($total/$limit) + (($total % $limit) > 0 ? 1 : 0);
>-                my $url = "/cgi-bin/koha/reports/guided_reports.pl?id=$report_id&amp;op=run&amp;limit=$limit&amp;want_full_chart=$want_full_chart";
>+                my $url = "/cgi-bin/koha/reports/guided_reports.pl?id=$report_id&op=run&limit=$limit&want_full_chart=$want_full_chart";
>                 if (@param_names) {
>-                    $url = join('&amp;param_name=', $url, map { URI::Escape::uri_escape_utf8($_) } @param_names);
>+                    $url = join('&param_name=', $url, map { URI::Escape::uri_escape_utf8($_) } @param_names);
>                 }
>                 if (@sql_params) {
>-                    $url = join('&amp;sql_params=', $url, map { URI::Escape::uri_escape_utf8($_) } @sql_params);
>+                    $url = join('&sql_params=', $url, map { URI::Escape::uri_escape_utf8($_) } @sql_params);
>                 }
> 
>                 if ($template_id) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37595: 170162 | 170170 | 170432