Attachment 170433 Details for Bug 37580 – Bug 37580: Unique Holidays Description are not editable

[patch] Bug 37580: Unique Holidays Description are not editable

Bug-37580-Unique-Holidays-Description-are-not-edit.patch (text/plain), 2.48 KB, created by Marcel de Rooy on 2024-08-16 07:30:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-08-16 07:30:42 UTC

Size: 2.48 KB

patch

obsolete

>From 3c94b060a1aff6a6c8960ef5d903772182703b1b Mon Sep 17 00:00:00 2001
>From: CJ Lynce <cj.lynce@westlakelibrary.org>
>Date: Tue, 6 Aug 2024 14:30:51 +0000
>Subject: [PATCH] Bug 37580: Unique Holidays Description are not editable
>Content-Type: text/plain; charset=utf-8
>
>Holiday names and descriptions are not editable after creation in
>    tools/holiday.pl.
>This patch corrects this regression.
>
>To test:
>
>1) Login to staff client
>2) Open Tools -> Calendar
>3) Click on a date and create a holiday with name and description.
>4) Save holiday.
>5) Click on newly created holiday on calendar and edit the name and
>   description.
>6) Re-Save Holiday.
>7) Click again on holiday, and see that name and description changes
>   did not save.
>8) Apply patch
>9) Repeat steps 5-7
>10) Verify that changes now save.
>
>Sponsored-by: Westlake Porter Public Library
>Signed-off-by: Martha <msulllivan@rcls.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
>index 3b91f370ee..32366ec40d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
>@@ -124,7 +124,7 @@
>                                                 <div class="hint">This will delete the exceptions inside a given range. Be careful about your scope range; if it is oversized you could slow down Koha.</div>
>                                             </li>
>                                             <li class="radio">
>-                                                <input type="radio" name="showOperation" id="showOperationEdit" value="edit" checked="checked" /> <label for="showOperationEdit">Edit this holiday</label>
>+                                                <input type="radio" name="showOperation" id="showOperationEdit" value="cud-edit" checked="checked" /> <label for="showOperationEdit">Edit this holiday</label>
>                                                 <a href="#" class="helptext">[?]</a>
>                                                 <div class="hint">This will save changes to the holiday's title and description. If the information for a repeatable holiday is modified, it affects all of the dates on which the holiday is repeated.</div></li>
>                                             <li class="checkbox">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37580: 170101 | 170112 | 170433