Attachment 170455 Details for Bug 34610 – Bug 34610: Update deprecated ProtectSuperlibrarian string

[patch] Bug 34610: Update deprecated ProtectSuperlibrarian string

Bug-34610-Update-deprecated-ProtectSuperlibrarian-.patch (text/plain), 1.81 KB, created by Katrin Fischer on 2024-08-16 15:16:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2024-08-16 15:16:21 UTC

Size: 1.81 KB

patch

obsolete

>From e0320aabd9e0564420b7f64ca8f31893129ca932 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?No=C3=A9mie=20Ariste?= <noemie.ariste@catalyst.net.nz>
>Date: Thu, 25 Jul 2024 23:57:24 +0000
>Subject: [PATCH] Bug 34610: Update deprecated ProtectSuperlibrarian string
>
>Test:
>1. Set ProtectSuperlibrarianPrivileges system preference to Allow only
>   superlibrarians
>2. Give superlibrarian permissions to a user (User 1)
>3. Give catalogue, borrowers, permissions, and staffaccess  permissions
>   to a second user (User 2)
>3. Login as User 2
>4. Go to User 1 permission settings page.
>5. Hover over the Select all and Clear all links.
>6. Check the message that appears contains
>   ProtectSuperlibrarianPrivileges and not ProtectSuperlibrarian
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
>index 8e995e96498..e30f0081c71 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
>@@ -144,7 +144,7 @@
>             [% IF disable_superlibrarian_privs && patron.is_superlibrarian %]
>                 $("#CheckAllFlags,#UncheckAllFlags")
>                     .attr("disabled", true)
>-                    .attr("title", _("The system preference ProtectSuperlibrarian is enabled"))
>+                    .attr("title", _("The system preference ProtectSuperlibrarianPrivileges is enabled"))
>                     .on("click", function(e){e.preventDefault()});
>             [% ELSE %]
>                 $("#CheckAllFlags").on("click",function(){
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 34610: 169633 | 170201 | 170321 | 170322 | 170455