Attachment 170462 Details for Bug 37612 – Bug 37612: Batch patron modification should accept both cud-show and show ops

[patch] Bug 37612: Batch patron modification should accept both cud-show and show ops

Bug-37612-Batch-patron-modification-should-accept-.patch (text/plain), 2.08 KB, created by David Nind on 2024-08-17 03:55:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-08-17 03:55:53 UTC

Size: 2.08 KB

patch

obsolete

>From 38b65b446a01a096a3cdf429c76fc37d4dd7d6ad Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Fri, 9 Aug 2024 15:43:50 -0700
>Subject: [PATCH] Bug 37612: Batch patron modification should accept both
> cud-show and show ops
>
>Just like with batch item modification, batch patron modification can accept
>either a POST of a lot of data, which might be more than Apache's default
>URL length limit, or a GET of a little data. Or at least it could, if both
>the op 'cud-show' and the op 'show' were accepted. Show isn't doing any
>creation or updating or deleting, it just has to be cud-show because it needs
>to be able to accept large POSTs. So when it is only getting a little data, it
>should be willing to take a GET with op=show just like batch item
>modification does.
>
>Test plan:
>1. Without the patch, Tools - Patron lists - New patron list - give it a
>   name and Save
>2. Type enough characters in the Patron search input to find a patron (I
>   like ace for poor often-used Henry Acevedo) and click on a patron in
>   the list of results
>3. Click Add patrons
>4. Click Patron lists, and in the Actions menu for your list, choose
>   Batch edit patrons. Note that the page that loads doesn't show any patrons
>   or UI to edit them, only a message about "No patron card numbers or
>   borrowernumbers given."
>5. Apply patch, restart_all
>6. Repeat step 4, but this time get a page with your patron listed, and a
>   form to change things about the patron record.
>
>Sponsored-by: Chetco Community Public Library
>Signed-off-by: David Nind <david@davidnind.com>
>---
> tools/modborrowers.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 006d219275..6492d2f07b 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -56,7 +56,7 @@ $template->param( CanUpdatePasswordExpiration => 1 ) if $logged_in_user->is_supe
> my $dbh       = C4::Context->dbh;
> 
> # Show borrower informations
>-if ( $op eq 'cud-show' ) {
>+if ( $op eq 'cud-show' || $op eq 'show' ) {
>     my @borrowers;
>     my @patronidnumbers;
>     my @notfoundcardnumbers;
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37612: 170223 | 170459 | 170462 | 170528