Attachment 170501 Details for Bug 35044 – Bug 35044: (QA follow-up): Add color to atomic update

[patch] Bug 35044: (QA follow-up): Add color to atomic update

Bug-35044-QA-follow-up-Add-color-to-atomic-update.patch (text/plain), 1.97 KB, created by Pedro Amorim on 2024-08-20 14:30:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-08-20 14:30:07 UTC

Size: 1.97 KB

patch

obsolete

>From 7f6c325f16962a811c57739cec71d5137e517e07 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Tue, 20 Aug 2024 14:27:54 +0000
>Subject: [PATCH] Bug 35044: (QA follow-up): Add color to atomic update
>
>---
> installer/data/mysql/atomicupdate/bug_35044.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_35044.pl b/installer/data/mysql/atomicupdate/bug_35044.pl
>index 2e5d94c272..f64e70014d 100755
>--- a/installer/data/mysql/atomicupdate/bug_35044.pl
>+++ b/installer/data/mysql/atomicupdate/bug_35044.pl
>@@ -1,4 +1,5 @@
> use Modern::Perl;
>+use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
> 
> return {
>     bug_number  => "35044",
>@@ -14,7 +15,7 @@ return {
>                         'does the field allow more than one option?' AFTER searchable
>                 }
>             );
>-            say $out "Added repeatable column to additional_fields table";
>+            say_success( $out, "Added repeatable column to additional_fields table" );
>         }
> 
>         if ( unique_key_exists ('additional_field_values', 'field_record') ) {
>@@ -39,12 +40,12 @@ return {
>                         `additional_fields` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
>                 }
>             );
>-            say $out "Removed UNIQUE KEY `field_record` (`field_id`,`record_id`) from the additional_field_values table";
>+            say_success( $out, "Removed UNIQUE KEY `field_record` (`field_id`,`record_id`) from the additional_field_values table" );
>         }
> 
>         my $number_of_entries = $dbh->do(q{DELETE FROM additional_field_values WHERE value = ''});
>         if ( defined $number_of_entries && $number_of_entries > 0 ) {
>-            say $out "Removed $number_of_entries redundant additional_field_values entries with empty value";
>+            say_info( $out, "Removed $number_of_entries redundant additional_field_values entries with empty value" );
>         }
>     },
> };
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35044: 157324 | 157325 | 157326 | 157327 | 157328 | 157329 | 157330 | 157331 | 157332 | 157333 | 157334 | 158113 | 158498 | 158499 | 158500 | 158501 | 158502 | 158503 | 158504 | 158505 | 158506 | 158507 | 158508 | 158857 | 158858 | 158859 | 158860 | 158861 | 158862 | 158863 | 158864 | 158865 | 158866 | 158867 | 158868 | 159268 | 160177 | 160178 | 160179 | 160180 | 160181 | 160182 | 160183 | 160184 | 160185 | 160186 | 160187 | 160188 | 160189 | 164162 | 164163 | 164164 | 164165 | 164166 | 164167 | 164168 | 164169 | 164170 | 164171 | 164172 | 164173 | 164174 | 167690 | 168537 | 168538 | 168539 | 168540 | 168541 | 168542 | 168543 | 168544 | 168545 | 168546 | 168547 | 168548 | 169545 | 169546 | 169547 | 169603 | 169604 | 169605 | 169606 | 169607 | 169643 | 169644 | 169645 | 169646 | 169647 | 169648 | 169649 | 169650 | 169651 | 169652 | 169653 | 169654 | 169655 | 169656 | 169657 | 169658 | 169659 | 169660 | 169661 | 169662 | 169663 | 169664 | 169665 | 169666 | 169667 | 169668 | 169669 | 169670 | 169671 | 169672 | 169673 | 169674 | 169675 | 169676 | 169677 | 169678 | 169679 | 169680 | 169681 | 169682 | 169683 | 169684 | 169697 | 170501