Bugzilla – Attachment 170530 Details for
Bug 37586
Improve accessibility of top navigation in the OPAC with aria-labels
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37586: Updated aria-labels for masthead links
Bug-37586-Updated-aria-labels-for-masthead-links.patch (text/plain), 3.74 KB, created by
Martin Renvoize (ashimema)
on 2024-08-21 08:13:26 UTC
(
hide
)
Description:
Bug 37586: Updated aria-labels for masthead links
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-08-21 08:13:26 UTC
Size:
3.74 KB
patch
obsolete
>From 677f760570bd211dc17a7d3cec4c44ea2a787165 Mon Sep 17 00:00:00 2001 >From: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Date: Wed, 7 Aug 2024 13:22:58 +0000 >Subject: [PATCH] Bug 37586: Updated aria-labels for masthead links >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Update to my last comment: The Lists aria-label had an accessibility issue as the label did not match the visible text. > >New test plan: > >Check the OPAC Interface: >* Open the OPAC in a normal-sized browser window. >* Youâll see the text next to the 'Cart', 'Lists', and 'Login' icons clearly. >* Gradually reduce the window size until the text next to these icons disappears. >* Inspect the icon elements. Youâll find that there is no alternative text (like aria-label) provided for 'Cart' and 'Login'. The aria-label for 'Lists' does not match the visible text. It currently says "Show dropdown with detailed list information". This lack of alternative text is an accessibility issue and labels should match visible text. >Apply the Patch: >* Apply the patch >* Restart_all >Verify the Fix: >* Inspect the icons again. >* For the 'Cart' icon, you should see an aria-label attribute with the text "View your shopping cart". >* For the 'Login' icon, you should see an aria-label attribute with the text "Log in to your account". >* For the 'Lists' icon, you should see an updated aria-label attribute with the new text of "Lists". >* These changes will improve accessibility for users relying on screen readers. >Sign Off: >* Sign off and Have an amazing day! > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 21780d429b0..96422f34919 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -37,7 +37,7 @@ > <ul id="cart-list-nav" class="navbar-nav"> > [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %] > <li class="nav-item js-show"> >- <a href="#" class="nav-link" title="Collect items you are interested in" id="cartmenulink" role="button"> >+ <a href="#" class="nav-link" title="Collect items you are interested in" id="cartmenulink" role="button" aria-label="Cart"> > <i id="carticon" class="fa fa-shopping-cart fa-icon-black" aria-hidden="true"></i> <span class="cartlabel">Cart</span> <span id="basketcount"></span> > </a> > </li> >@@ -45,7 +45,7 @@ > <li class="divider-vertical"></li> > [% IF ( Koha.Preference( 'virtualshelves' ) == 1 ) %] > <li class="nav-item dropdown"> >- <a href="/cgi-bin/koha/opac-shelves.pl" title="Show lists" class="nav-link dropdown-toggle" id="listsmenu" data-toggle="dropdown" role="button" aria-label="Show dropdown with detailed list information" aria-haspopup="true" aria-expanded="false" >+ <a href="/cgi-bin/koha/opac-shelves.pl" title="Show lists" class="nav-link dropdown-toggle" id="listsmenu" data-toggle="dropdown" role="button" aria-label="Lists" aria-haspopup="true" aria-expanded="false" > ><i class="fa fa-list fa-icon-black" aria-hidden="true"></i> <span class="listslabel">Lists</span> > </a> > <div aria-labelledby="listsmenu" role="menu" class="dropdown-menu"> >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37586
:
170118
|
170134
|
170135
|
170472
|
170473
| 170530 |
170531