Attachment 170558 Details for Bug 37636 – Bug 37636: Remove sort of pending_checkouts by timestamp

[patch] Bug 37636: Remove sort of pending_checkouts by timestamp

Bug-37636-Remove-sort-of-pendingcheckouts-by-times.patch (text/plain), 1.45 KB, created by Martin Renvoize (ashimema) on 2024-08-21 11:11:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-08-21 11:11:45 UTC

Size: 1.45 KB

patch

obsolete

>From 8d28d52c715526ad61dfea1001d046fb7b1bb592 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 20 Aug 2024 13:25:26 +0000
>Subject: [PATCH] Bug 37636: Remove sort of pending_checkouts by timestamp
>
>Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort
>on this field to functionally randomize the order of checkouts returned.
>
>Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order.
>
>Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting
>
>To test:
>1 - Checkout some items to a patron
>2 - Print a checkout slip - items are in the order they were checked out
>3 - Renew an item,print the slip again it is now at the top of the list
>4 - Apply patch, restart_all
>5 - Print slip again - the items are now ordered in the order they were checked out.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Patron.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 7234a3be5bc..121073e6793 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -1438,7 +1438,6 @@ sub pending_checkouts {
>         {},
>         {
>             order_by => [
>-                { -desc => 'me.timestamp' },
>                 { -desc => 'issuedate' },
>                 { -desc => 'issue_id' }, # Sort by issue_id should be enough
>             ],
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 37636: 170496 | 170556 | 170558 | 170604 | 170605 | 171453 | 171454