Attachment 170567 Details for Bug 37642 – Bug 37642: Generated letter should use https in header

[patch] Bug 37642: Generated letter should use https in header

Bug-37642-Generated-letter-should-use-https-in-hea.patch (text/plain), 1.26 KB, created by Paul Derscheid on 2024-08-21 14:47:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Derscheid

Created: 2024-08-21 14:47:13 UTC

Size: 1.26 KB

patch

obsolete

>From c55613b45aa7dc9bdba05f89f28e5e4a3b582cb6 Mon Sep 17 00:00:00 2001
>From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
>Date: Wed, 14 Aug 2024 10:55:16 +0200
>Subject: [PATCH] Bug 37642: Generated letter should use https in header
>
>_wrap_html returns a header referring to http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd and http://www.w3.org/1999/xhtml. These should be https links.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
>---
> C4/Letters.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 3f2fc95a4b..7bdbfc9bf2 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -1579,8 +1579,8 @@ sub _wrap_html {
>     $css = qq{<link rel="stylesheet" type="text/css" href="$css">} if $css;
>     return <<EOS;
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
>-    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
>-<html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
>+    "https://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
>+<html lang="en" xml:lang="en" xmlns="https://www.w3.org/1999/xhtml">
> <head>
> <title>$title</title>
> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 37642: 170308 | 170534 | 170567