Bugzilla – Attachment 17062 Details for
Bug 9002
Remove Problematic Logic from Patron Messaging Preferences Form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form
PASSED-QA-Bug-9002---Remove-Problematic-Logic-from.patch (text/plain), 1.81 KB, created by
Katrin Fischer
on 2013-03-30 22:19:21 UTC
(
hide
)
Description:
[PASSED QA] Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-03-30 22:19:21 UTC
Size:
1.81 KB
patch
obsolete
>From 82260c204dc9ad912352ca0436bd93e3b782965c Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 1 Nov 2012 08:17:08 +1100 >Subject: [PATCH] [PASSED QA] Bug 9002 - Remove Problematic Logic from Patron > Messaging Preferences Form > >If you do not have SMSSendDriver set and you do not have a message_transport_type of "sms", you will get an extra table column filled with a hyphen "-" and no corresponding table heading in the Patron Messaging Preferences table. > >This pushes the table out of alignment so the email checkbox goes under "Digests Only?", the digests checkbox goes under "Do not notify", and the Do not notify checkbox is pushed to the side with no heading. > >Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested for regressions. >All tests and QA script pass. >--- > .../prog/en/includes/messaging-preference-form.inc | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >index b08c5ca..ed6b067 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >@@ -52,7 +52,7 @@ > [% ELSE %] > <td>-</td> > [% END %] >- [% IF ( messaging_preference.transport_sms ) %] >+ > [% IF ( SMSSendDriver ) %]<td> > [% IF ( messaging_form_inactive ) %] > [% IF ( messaging_preference.transports_sms ) %] >@@ -80,9 +80,6 @@ > [% END %] > [% END %] > </td>[% END %] >- [% ELSE %] >- <td>-</td> >- [% END %] > > [% IF ( TalkingTechItivaPhone ) %]<td> > [% IF ( messaging_form_inactive ) %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9002
:
13159
|
13301
|
13302
|
16226
| 17062