Attachment 170634 Details for Bug 35905 – Bug 35905: Add permission checks to report results

[patch] Bug 35905: Add permission checks to report results

Bug-35905-Add-permission-checks-to-report-results.patch (text/plain), 5.74 KB, created by Brendan Lawlor on 2024-08-23 14:42:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Lawlor

Created: 2024-08-23 14:42:55 UTC

Size: 5.74 KB

patch

obsolete

>From 48b41a28d5280324588cc0cecc42500a7334fd1c Mon Sep 17 00:00:00 2001
>From: Brendan Lawlor <blawlor@clamsnet.org>
>Date: Fri, 19 Jul 2024 20:51:15 +0000
>Subject: [PATCH] Bug 35905: Add permission checks to report results
>
>Test plan:
>1. Apply patch
>2. Create a report like:
> select biblionumber from biblio limit 10
>2. Run the report
>3. Verify batch operations dropdown contains batch modification and deletion
>4. Run the report again as a user that has only catalogue and reports permissions
>5. Confirm the batch operations drop down only includes Add to list
>6. Confirm the records drop down only includes View record
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../modules/reports/guided_reports_start.tt | 20 +++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index f8b22a8a70..4bac39c5b4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1088,12 +1088,14 @@
> [% FOREACH header_ro IN header_row %]
> [% IF header_ro.has_biblionumbers && ( header_ro.cell == 'biblionumber' || header_types.item( header_ro.cell ) == 'biblionumber' ) %]
> <li class="dropdown-header">Bibliographic records</li>
>- <li>
>- <a href="#" data-submit="batch_record_modification" data-toggle="tooltip" data-placement="right" title="Send visible records to batch record modification" class="batch_op send_to_record_mod">Batch record modification</a>
>- </li>
>- <li>
>- <a href="#" data-submit="batch_record_deletion" data-toggle="tooltip" data-placement="right" title="Send visible records to batch record deletion" class="batch_op send_to_record_del">Batch record deletion</a>
>- </li>
>+ [% IF ( CAN_user_tools_items_batchmod || CAN_user_tools_items_batchdel ) %]
>+ <li>
>+ <a href="#" data-submit="batch_record_modification" data-toggle="tooltip" data-placement="right" title="Send visible records to batch record modification" class="batch_op send_to_record_mod">Batch record modification</a>
>+ </li>
>+ <li>
>+ <a href="#" data-submit="batch_record_deletion" data-toggle="tooltip" data-placement="right" title="Send visible records to batch record deletion" class="batch_op send_to_record_del">Batch record deletion</a>
>+ </li>
>+ [% END # /IF CAN_user_tools_items_batchmod || CAN_user_tools_items_batchdel %]
> <li>
> <a href="#" data-submit="batch_add_to_list" data-toggle="tooltip" data-placement="right" title="Send visible records to a list" class="batch_op send_to_list">Add to list</a>
> </li>
>@@ -1197,8 +1199,10 @@
> [% cells.cell | $raw %]
> <div id="biblionumber_autolink" class="btn-group dropup autolink"><a class="btn btn-link dropdown-toggle" role="button" data-toggle="dropdown" href="#">[% cells.cell | $raw %] </a>
> <ul class="dropdown-menu pull-right" role="menu">
>- <li><a target="_blank" href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% cells.cell | $raw %]"> Edit record</a></li>
>- <li role="separator" class="divider"></li>
>+ [% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items ) %]
>+ <li><a target="_blank" href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% cells.cell | $raw %]"> Edit record</a></li>
>+ <li role="separator" class="divider"></li>
>+ [% END # /IF CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items %]
> <li><a target="_blank" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% cells.cell | $raw %]"> View record</a></li>
> </ul>
> </div>
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35905: 169260 | 169263 | 170440 | 170634 | 170635 | 170636 | 171105 | 171492