Attachment 17064 Details for Bug 9605 – [PASSED QA] Bug 9605: rotating collections permissions are wrong

[patch] [PASSED QA] Bug 9605: rotating collections permissions are wrong

PASSED-QA-Bug-9605-rotating-collections-permission.patch (text/plain), 3.30 KB, created by Katrin Fischer on 2013-03-30 22:38:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-03-30 22:38:31 UTC

Size: 3.30 KB

patch

obsolete

>From 9bba654c25b4e85556b2fa9fcebbf3117fa55e99 Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Wed, 13 Feb 2013 10:29:15 +0100
>Subject: [PATCH] [PASSED QA] Bug 9605: rotating collections permissions are
> wrong
>
>In tools / rotating collections, permissions are 'parameters => 1'.
>But there is a dedicated permission : tools => rotating_collections.
>
>Test plan :
>- Disable tools/rotating_collections permission to your connected user
>- Check you dont have access to those pages :
>  rotating_collections/addItems.pl
>  rotating_collections/editCollections.pl
>  rotating_collections/rotatingCollections.pl
>  rotating_collections/transferCollection.pl
>- Enable tools/rotating_collections permission to your connected user
>- Check you have access to above pages
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Fixes wrong permission on rotating collection related pages.
>This will allow to block access to those.
>---
> rotating_collections/addItems.pl            |    2 +-
> rotating_collections/editCollections.pl     |    2 +-
> rotating_collections/rotatingCollections.pl |    2 +-
> rotating_collections/transferCollection.pl  |    2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl
>index ae7070f..06b6b3a 100755
>--- a/rotating_collections/addItems.pl
>+++ b/rotating_collections/addItems.pl
>@@ -34,7 +34,7 @@ my ($template, $loggedinuser, $cookie)
> 			     query => $query,
> 			     type => "intranet",
> 			     authnotrequired => 0,
>-			     flagsrequired => {parameters => 1},
>+                          flagsrequired => { tools => 'rotating_collections' },
> 			     debug => 1,
> 			     });
> 
>diff --git a/rotating_collections/editCollections.pl b/rotating_collections/editCollections.pl
>index 4c4849c..e386608 100755
>--- a/rotating_collections/editCollections.pl
>+++ b/rotating_collections/editCollections.pl
>@@ -33,7 +33,7 @@ my ($template, $loggedinuser, $cookie)
> 			     query => $query,
> 			     type => "intranet",
> 			     authnotrequired => 0,
>-			     flagsrequired => {parameters => 1},
>+                          flagsrequired => { tools => 'rotating_collections' },
> 			     debug => 1,
> 			     });
> 
>diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl
>index 52ee5ee..35aea56 100755
>--- a/rotating_collections/rotatingCollections.pl
>+++ b/rotating_collections/rotatingCollections.pl
>@@ -33,7 +33,7 @@ my ($template, $loggedinuser, $cookie)
> 			     query => $query,
> 			     type => "intranet",
> 			     authnotrequired => 0,
>-			     flagsrequired => {parameters => 1},
>+                          flagsrequired => { tools => 'rotating_collections' },
> 			     debug => 1,
> 			     });
> 
>diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl
>index 39945d5..23eff46 100755
>--- a/rotating_collections/transferCollection.pl
>+++ b/rotating_collections/transferCollection.pl
>@@ -38,7 +38,7 @@ my ($template, $loggedinuser, $cookie)
> 			     query => $query,
> 			     type => "intranet",
> 			     authnotrequired => 0,
>-			     flagsrequired => {parameters => 1},
>+                          flagsrequired => { tools => 'rotating_collections' },
> 			     debug => 1,
> 			     });
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9605: 15292 | 15294 | 17064