Attachment 170680 Details for Bug 30745 – Bug 30745 : Fix error 500 when item is not found while using zebra

[patch] Bug 30745 : Fix error 500 when item is not found while using zebra

Bug-30745--Fix-error-500-when-item-is-not-found-wh.patch (text/plain), 1.64 KB, created by Hammat wele on 2024-08-23 20:23:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hammat wele

Created: 2024-08-23 20:23:18 UTC

Size: 1.64 KB

patch

obsolete

>From dd4a959ef702424c98c8f3548490915f64a7890c Mon Sep 17 00:00:00 2001
>From: Hammat Wele <hammat.wele@inlibro.com>
>Date: Fri, 23 Aug 2024 20:21:22 +0000
>Subject: [PATCH] Bug 30745 : Fix error 500 when item is not found while using
> zebra
>
>Plan test :
>- Apply this batch
>- Set Zebra as searchEngine
>- Go to Cataloging -> # Label creator
>- Click on New, Select Label batch
>- Click on Add item(s)
>- Search for for inexisting items
>=> The page should refresh itself (so that it has the same behavior as elasticSearch)
>---
> labels/label-item-search.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/labels/label-item-search.pl b/labels/label-item-search.pl
>index 8cebec8278..6586fa9c40 100755
>--- a/labels/label-item-search.pl
>+++ b/labels/label-item-search.pl
>@@ -42,6 +42,8 @@ my $op        = $query->param('op') || '';
> my $batch_id  = $query->param('batch_id');
> my @limits    = split(" AND ", $query->param('limits') || "");
> my $startfrom = $query->param('startfrom') || 1;
>+Koha::Logger->get->warn('$batch_id');
>+Koha::Logger->get->warn($batch_id);
> my ($template, $loggedinuser, $cookie) = (undef, undef, undef);
> my (
>     $total_hits,  $total,  $error,
>@@ -85,7 +87,7 @@ if ( $op eq "do_search" ) {
>         undef, undef, $query_type, undef
>     );
> 
>-    if (!defined $error && @{$results->{biblioserver}{RECORDS}} ) {
>+    if (!defined $error && defined($results) && @{$results->{biblioserver}{RECORDS}} > 0 ) {
>         $show_results = grep { defined $_ } @{$results->{biblioserver}{RECORDS}};
>         $marcresults = [ grep { defined $_ } @{$results->{biblioserver}{RECORDS}} ];
>         $total_hits = $results->{biblioserver}{hits};
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30745: 134952 | 134953 | 135784 | 135785 | 135966 | 135967 | 157192 | 157194 | 157195 | 157934 | 162855 | 163955 | 170677 | 170678 | 170679 | 170680 | 170681 | 170682 | 170683 | 170684 | 170729 | 170730 | 170731 | 170732 | 170733 | 171002 | 171003 | 171004 | 171005 | 171006 | 173280 | 173943 | 173944 | 173945 | 173946 | 173947 | 174486 | 174487 | 174488 | 174489 | 174490 | 174491