Attachment 170700 Details for Bug 37309 – Bug 37309: Adjust test

[patch] Bug 37309: Adjust test

Bug-37309-Adjust-test.patch (text/plain), 1.08 KB, created by Jonathan Druart on 2024-08-26 08:59:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-08-26 08:59:36 UTC

Size: 1.08 KB

patch

obsolete

>From 36dcfcdd96be740fb67fe0ca0932375e38329409 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 26 Aug 2024 10:57:56 +0200
>Subject: [PATCH] Bug 37309: Adjust test
>
>The test to catch wrong "op" in posted form was not supporting single
>quotes.
>---
> xt/find-missing-op-in-forms.t | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/xt/find-missing-op-in-forms.t b/xt/find-missing-op-in-forms.t
>index e072344858b..3958a1fbd32 100755
>--- a/xt/find-missing-op-in-forms.t
>+++ b/xt/find-missing-op-in-forms.t
>@@ -58,10 +58,10 @@ sub catch_missing_op {
>             $in_form        = 1;
>             $line_open_form = $line_number;
>         }
>-        if ( $in_form && $line =~ m{name="op"} ) {
>+        if ( $in_form && $line =~ m{name=('|")op('|")} ) {
>             $has_op = 1;
>-            if ( $line =~ m{value="(.*)"} ) {
>-                $op_value = $1;
>+            if ( $line =~ m{value=('|")([^'"]*)('|")} ) {
>+                $op_value = $2;
>             }
>         }
>         if ( $in_form && $line =~ m{</form} ) {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37309: 168777 | 168797 | 168798 | 168799 | 168802 | 168844 | 168845 | 168846 | 168847 | 168848 | 170307 | 170309 | 170700