Bugzilla – Attachment 17072 Details for
Bug 9954
CSV profile encoding not selected on editing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9954 - CVS profile encoding not selected in edition
Bug-9954---CVS-profile-encoding-not-selected-in-ed.patch (text/plain), 2.14 KB, created by
Chris Cormack
on 2013-03-31 03:48:25 UTC
(
hide
)
Description:
Bug 9954 - CVS profile encoding not selected in edition
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-03-31 03:48:25 UTC
Size:
2.14 KB
patch
obsolete
>From 21734c7126ada9adf93cf26e2d4dd6e30f4af2bf Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Fri, 29 Mar 2013 14:53:45 +0100 >Subject: [PATCH] Bug 9954 - CVS profile encoding not selected in edition > >When editing an existing CSV profile, its encoding is not selected in combobox, first value "ascii" is always selected. > >This patch corrects this (surely appeared with TT conversion) and also the fact that "uft8" is by default selected in creation form. > >Test plan: >- Go to Tools/CSV Profiles >- In "New prodile" tab >=> Check that "uft8" is selected >- Create a new profile by entering name, an encoding (other than the first), and MARC fields >- Click on "Edit existing profile" tab >- Select created profile >=> Check that specified encoding is selected > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt >index 2d98836..a941876 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt >@@ -101,7 +101,7 @@ function reloadPage(p) { > <li><label for="new_encoding">Encoding: </label> > <select name="encoding" id="new_encoding"> > [% FOREACH encoding IN encodings %] >- [% IF ( encoding == 'utf8' ) %] >+ [% IF ( encoding.encoding == 'utf8' ) %] > <option selected="selected">[% encoding.encoding %]</option> > [% ELSE %] > <option>[% encoding.encoding %]</option> >@@ -281,7 +281,7 @@ function reloadPage(p) { > <li><label for="encoding">Encoding: </label> > <select name="encoding" id="encoding"> > [% FOREACH encoding IN encodings %] >- [% IF ( selected_encoding == encoding ) %] >+ [% IF ( selected_encoding == encoding.encoding ) %] > <option selected="selected">[% encoding.encoding %]</option> > [% ELSE %] > <option>[% encoding.encoding %]</option> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9954
:
17029
|
17072
|
17086