Attachment 170728 Details for Bug 37734 – Bug 37734: Fix insert runtime parameter button in reports

[patch] Bug 37734: Fix insert runtime parameter button in reports

Bug-37734-Fix-insert-runtime-parameter-button-in-r.patch (text/plain), 3.72 KB, created by Brendan Lawlor on 2024-08-26 15:06:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Lawlor

Created: 2024-08-26 15:06:56 UTC

Size: 3.72 KB

patch

obsolete

>From 8527435c04001a41f3c5c2ceec3faaaa9d0cee38 Mon Sep 17 00:00:00 2001
>From: Brendan Lawlor <blawlor@clamsnet.org>
>Date: Mon, 26 Aug 2024 15:02:34 +0000
>Subject: [PATCH] Bug 37734: Fix insert runtime parameter button in reports
>
>To test:
>1. Go to Reports > Create from SQL
>2. Click the Insert runtime parameter button
>3. Click on any of the drop down options
>4. Nothing happens :(
>5. Apply patch
>6. Repeat steps 2 and 3 for all different parameters
>7. Notice the modal launches :)
>8. Confirm the parameters are inserted as expected
>---
> .../modules/reports/guided_reports_start.tt   | 24 +++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index e55218e360..25d1e71f5b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -2552,18 +2552,18 @@
>             Insert runtime parameter
>         </button>
>         <ul class="dropdown-menu">
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertAuthVal">Authorized values</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertFramework">Bibliographic framework</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertCnSource">Classification sources</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertDate">Date</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertItemtypes">Item types</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertBranches">Libraries</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertList">List</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertCategorycode">Patron categories</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertCashregister">Cash registers</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertDebittypes">Debit types</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertCredittypes">Credit types</a></li>
>-            <li><a class="dropdown-item" href="#" class="insertParam" id="insertText">Text field</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertAuthVal">Authorized values</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertFramework">Bibliographic framework</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertCnSource">Classification sources</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertDate">Date</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertItemtypes">Item types</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertBranches">Libraries</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertList">List</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertCategorycode">Patron categories</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertCashregister">Cash registers</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertDebittypes">Debit types</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertCredittypes">Credit types</a></li>
>+            <li><a class="dropdown-item insertParam" href="#" id="insertText">Text field</a></li>
>         </ul>
>     </div>
> [% END %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37734: 170728 | 170734 | 170739 | 170740 | 170741 | 170775