Bugzilla – Attachment 170774 Details for
Bug 36085
Setting and unsetting the protected flag should be limited to superlibrarian accounts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36085: (QA follow-up) Tidy members/memberentry.pl
Bug-36085-QA-follow-up-Tidy-membersmemberentrypl.patch (text/plain), 2.74 KB, created by
Paul Derscheid
on 2024-08-27 14:15:41 UTC
(
hide
)
Description:
Bug 36085: (QA follow-up) Tidy members/memberentry.pl
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2024-08-27 14:15:41 UTC
Size:
2.74 KB
patch
obsolete
>From 5cd03b2359583b415286c4420d88285261ce75a3 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Tue, 27 Aug 2024 16:04:59 +0200 >Subject: [PATCH] Bug 36085: (QA follow-up) Tidy members/memberentry.pl > >--- > members/memberentry.pl | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index df7d92f18a..2fa5447e4d 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -173,7 +173,7 @@ if ( $op eq 'edit_form' or $op eq 'cud-save' or $op eq 'duplicate' ) { > } > if ($logged_in_user->is_superlibrarian) { > $CanUpdatePasswordExpiration = 1; >- $CanUpdateProtectPatron = 1; >+ $CanUpdateProtectPatron = 1; > } > > $borrower_data = $patron->unblessed; >@@ -235,7 +235,7 @@ if ( $op eq 'cud-insert' || $op eq 'edit_form' || $op eq 'cud-save' || $op eq 'd > map { qr/^$_$/ } > grep { $_ ne 'dateexpiry' } split( /\s*\|\s*/, C4::Context->preference('BorrowerUnwantedField') || q{} ); > push @keys_to_delete, qr/^password_expiration_date$/ unless $CanUpdatePasswordExpiration; >- push @keys_to_delete, qr/^protected$/ unless $CanUpdateProtectPatron; >+ push @keys_to_delete, qr/^protected$/ unless $CanUpdateProtectPatron; > for my $regexp (@keys_to_delete) { > for (keys %newdata) { > delete($newdata{$_}) if /$regexp/; >@@ -798,18 +798,18 @@ $template->param( > ); > > $template->param( >- patron => $patron ? $patron : \%newdata, # Used by address include templates now >- nodouble => $nodouble, >- borrowernumber => $borrowernumber, #register number >- relshiploop => \@relshipdata, >- btitle=> $default_borrowertitle, >- modify => $modify, >- nok => $nok,#flag to know if an error >- NoUpdateLogin => $NoUpdateLogin, >- NoUpdateEmail => $NoUpdateEmail, >- CanUpdatePasswordExpiration => $CanUpdatePasswordExpiration, >- CanUpdateProtectPatron => $CanUpdateProtectPatron, >- ); >+ patron => $patron ? $patron : \%newdata, # Used by address include templates now >+ nodouble => $nodouble, >+ borrowernumber => $borrowernumber, #register number >+ relshiploop => \@relshipdata, >+ btitle => $default_borrowertitle, >+ modify => $modify, >+ nok => $nok, #flag to know if an error >+ NoUpdateLogin => $NoUpdateLogin, >+ NoUpdateEmail => $NoUpdateEmail, >+ CanUpdatePasswordExpiration => $CanUpdatePasswordExpiration, >+ CanUpdateProtectPatron => $CanUpdateProtectPatron, >+); > > # HouseboundModule data > $template->param( >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36085
:
169127
|
169129
|
170773
| 170774