Bugzilla – Attachment 170785 Details for
Bug 37238
Add table settings to itemsearch results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37238: Move filters from tfoot to thead
Bug-37238-Move-filters-from-tfoot-to-thead.patch (text/plain), 1.99 KB, created by
Lucas Gass (lukeg)
on 2024-08-27 20:51:15 UTC
(
hide
)
Description:
Bug 37238: Move filters from tfoot to thead
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-08-27 20:51:15 UTC
Size:
1.99 KB
patch
obsolete
>From c663097554d3aa48b11705bb3c48bc7be225df84 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 27 Aug 2024 20:50:52 +0000 >Subject: [PATCH] Bug 37238: Move filters from tfoot to thead > >--- > .../prog/en/modules/catalogue/itemsearch.tt | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index 6b7815141ab..d21d0ec1f21 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -517,8 +517,7 @@ > + ' </div>' > + ' </div>' > + ' <table id="results">' >- + ' <thead>' + tr + '</thead>' >- + ' <tfoot>' + tr + '</tfoot>' >+ + ' <thead>' + tr + tr + '</thead>' > + ' <tbody></tbody>' > + ' </table>' > + '</div>'; >@@ -632,13 +631,13 @@ > "initComplete": function() { > $('#results').DataTable().columns().every(function () { > let column = this; >- let columnName = $(column.footer()).data('colname'); >- let title = column.footer().textContent; >+ let columnName = $(column.header()).data('colname'); >+ let title = column.header().textContent; > > let input = document.createElement('input'); > input.classList.add('text_filter', 'form-control' , 'search_init'); > input.placeholder = title; >- column.footer().replaceChildren(input); >+ column.header().replaceChildren(input); > > input.addEventListener('keyup', () => { > if (column.search() !== this.value) { >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37238
:
168409
|
168411
|
168483
|
170785
|
171037
|
173414
|
173415
|
173416
|
173740
|
173765
|
173766
|
173768
|
173785
|
173786
|
173787