Attachment 170791 Details for Bug 37752 – Bug 37752: Add missing class to navigation tab links

[patch] Bug 37752: Add missing class to navigation tab links

Bug-37752-Add-missing-class-to-navigation-tab-link.patch (text/plain), 2.74 KB, created by David Nind on 2024-08-27 22:54:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-08-27 22:54:02 UTC

Size: 2.74 KB

patch

obsolete

>From 377bf8b66d6556f760ddfca235cabeeda2f63090 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 27 Aug 2024 20:11:23 +0000
>Subject: [PATCH] Bug 37752: Add missing class to navigation tab links
>
>To test:
>1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
>2. Notice the tabs at the top have no style.
>3. APPLY PATCH
>4. 1 -3 again, tabs should look right.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/admin/marc_subfields_structure.tt         | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>index d5ef541220..617a66963b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>@@ -115,9 +115,9 @@
>                                     [% FOREACH loo IN loop %]
>                                         <li id="tab_subfield_[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]" class="tab-item" role="presentation">
>                                             [% IF ( loo.new_subfield ) %]
>-                                                <a href="#sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" aria-controls="sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" role="tab" data-bs-toggle="tab" title="[% loo.liblibrarian | html_entity %]">New</a>
>+                                                <a href="#sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" class="nav-link" aria-controls="sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" role="tab" data-bs-toggle="tab" title="[% loo.liblibrarian | html_entity %]">New</a>
>                                             [% ELSE %]
>-                                                <a href="#sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" aria-controls="sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" role="tab" data-bs-toggle="tab" title="[% loo.liblibrarian | html_entity %]">
>+                                                <a href="#sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" class="nav-link" aria-controls="sub[%- PROCESS outputsubfield subfieldanchor = loo.subfieldcode -%]field" role="tab" data-bs-toggle="tab" title="[% loo.liblibrarian | html_entity %]">
>                                                     [% loo.subfieldcode | html %]
>                                                 </a>
>                                             [% END %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37752: 170783 | 170791 | 170863