Attachment 17084 Details for Bug 9947 – [PASSED QA] Bug 9947 - Creating item for received serial prefills enumchron subfield

[patch] [PASSED QA] Bug 9947 - Creating item for received serial prefills enumchron subfield

PASSED-QA-Bug-9947---Creating-item-for-received-se.patch (text/plain), 2.55 KB, created by Katrin Fischer on 2013-03-31 11:36:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-03-31 11:36:46 UTC

Size: 2.55 KB

patch

obsolete

>From 1565e7551bac26095fb9ef002f50bbe8c03b6d5f Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Thu, 28 Mar 2013 15:52:13 +0100
>Subject: [PATCH] [PASSED QA] Bug 9947 - Creating item for received serial
> prefills enumchron subfield
>
>In serial receiving :
>When creating an item for an issue, a javascript prefilles the $h subfield with issue number.
>This is for MARC21, in UNIMARC serial number is on $v.
>
>This patch replaces hard-coded value with the subfield mapped with "items.enumchron".
>
>Test plan :
>- Set "Koha to MARC mapping" of "items.enumchron" on a subfield other than $h, ie $z
>- Go to a serial subscription detail with "Serial receipt creates an item record"
>- Click on "Receive"
>- On an issue, click on "Click to add item"
>=> Check that issue number is copied into selected subfield, ie $z
>You may test that with no mapping of "items.enumchron" there is no javascript error
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Nice catch! Works as advertised.
>All patch pass after fixing tabulation characters in serials-edit.tt.
>---
> .../prog/en/modules/serials/serials-edit.tt        |   14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>index 6ab28c7..5c8c80c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>@@ -68,13 +68,13 @@ function unHideItems(index,labelindex, serialId) {
> 	label = document.getElementById(labelindex);
> 	label.style.display='none';	
> 
>-	// Prefilling 995$h with serial enumeration/issue number
>-	// Getting item id
>-	itemid = $("fieldset#" + index + " div.cataloguing_additem_itemlist div.items").attr("id");
>-	// Getting subfield id
>-	subfieldid = "subfield" + itemid.substr(4) + "h";
>-	// Setting text field 
>-	$("#" + subfieldid + " input[type='text']").val($("#serialseq" + serialId).val());
>+    // Prefilling enumcron subfield with serial enumeration/issue number
>+    // Getting item div
>+    item_div = $("fieldset#" + index + " div.cataloguing_additem_itemlist div.items");
>+    // Getting subfield with enumcron mapping
>+    subfield_div = $(item_div).find("input[name='kohafield'][value='items.enumchron']").parent();
>+    // Setting text field
>+    $(subfield_div).children("input[type='text'][name='field_value']").val($("#serialseq" + serialId).val());
> 
> }
> function HideItems(index,labelindex) {
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9947: 16976 | 17074 | 17084 | 17085