Attachment 170866 Details for Bug 37745 – Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

[patch] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

Bug-37745-bug-35402-follow-up-Fix-Rows-per-page-dr.patch (text/plain), 2.59 KB, created by Owen Leonard on 2024-08-29 11:35:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-08-29 11:35:19 UTC

Size: 2.59 KB

patch

obsolete

>From 94d96ed8d836da574e598b71d251270a9bb2a839 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 27 Aug 2024 12:53:49 +0200
>Subject: [PATCH] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown
> items
>
>There were 2 class attributes.
>
>Test plan:
>Create a new report and run it
>Use the "Rows per page" dropdown to select another value
>=> Without this patch nothing happens
>=> With this patch applied the page is reloaded and the correct number
>of rows is displayed
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/modules/reports/guided_reports_start.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 3a4ca5778c..99bacfa3e9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1128,11 +1128,11 @@
> [% FOREACH l IN limits %]
> [% IF l == limit %]
> <li>
>- <a class="dropdown-item" class="limitselect" data-limit="[% l | html %]" href="#"> [% l | html %]</a>
>+ <a class="dropdown-item limitselect" data-limit="[% l | html %]" href="#"> [% l | html %]</a>
> </li>
> [% ELSE %]
> <li>
>- <a class="dropdown-item" class="limitselect" data-limit="[% l | html %]" href="#"> [% l | html %]</a>
>+ <a class="dropdown-item limitselect" data-limit="[% l | html %]" href="#"> [% l | html %]</a>
> </li>
> [% END %]
> [% END %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37745: 170760 | 170772 | 170776 | 170858 | 170859 | 170866 | 170867 | 170868 | 170869 | 170943 | 170944 | 170945 | 170946