Bugzilla – Attachment 170870 Details for
Bug 37525
Self checkout: "Return this item" doesn't show up in scan confirmation screen despite SCOAllowCheckin being allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch to fix the regression
0001-Bug-37525-SCO-Regression-in-32256-Return-this-item-d.patch (text/plain), 1.71 KB, created by
Oliver Behnke
on 2024-08-29 12:29:40 UTC
(
hide
)
Description:
Patch to fix the regression
Filename:
MIME Type:
Creator:
Oliver Behnke
Created:
2024-08-29 12:29:40 UTC
Size:
1.71 KB
patch
obsolete
>From 0a16cae9d24bd66508be0628480847c0e332a5f6 Mon Sep 17 00:00:00 2001 >From: Oliver Behnke <oliver.behnke@aei.mpg.de> >Date: Tue, 20 Aug 2024 19:37:36 +0300 >Subject: [PATCH] Bug 37525 - [SCO] Regression in 32256: "Return this item" > doesn't show up despite SCOAllowCheckin being allowed > >There's a regression in bug 32256 and commit bb059abe respectively: > >https://gitlab.com/koha-community/Koha/-/commit/bb059abe90#a22dc682a84c41672294c66e441329a451b5cd5a_137_137 > >The refactoring of "renew" -> "c.renew" missed this line (at least), so the condition is never met. > >This fixes the issue and restores the original functionality. > >Signed-off-by: Oliver Behnke <oliver.behnke@aei.mpg.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index d0896ec024..c11b62dd8d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -135,7 +135,7 @@ > <p>This item is already checked out to you: <b>[% c.confirm | html %]</b> <i>([% c.barcode | html %])</i></p> > [% END %] > >- [% IF ( renew && Koha.Preference('SCOAllowCheckin') ) %] >+ [% IF ( c.renew && Koha.Preference('SCOAllowCheckin') ) %] > <form action="/cgi-bin/koha/sco/sco-main.pl" name="confirmForm" class="inline" method="post"> > [% INCLUDE 'csrf-token.inc' %] > <legend class="sr-only">Return</legend> >-- >2.46.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37525
:
169856
|
170870
|
171034
|
172118