Attachment 170871 Details for Bug 37740 – Bug 37740: Fix saved SQL reports tab switching

[patch] Bug 37740: Fix saved SQL reports tab switching

Bug-37740-Fix-saved-SQL-reports-tab-switching.patch (text/plain), 1.89 KB, created by Chloe Zermatten on 2024-08-29 14:16:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chloe Zermatten

Created: 2024-08-29 14:16:42 UTC

Size: 1.89 KB

patch

obsolete

>From c370049869f40caa314f183eff802b493d17cb5a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 28 Aug 2024 18:28:57 +0000
>Subject: [PATCH] Bug 37740: Fix saved SQL reports tab switching
>
>The tabs on the saved SQL report page are not really full tabs, they're
>just styled that way. There is only one tab "panel," and clicking each
>tab triggers a DataTable filter so that the tab only shows the relevant
>data.
>
>The problem with this setup is that when Bootstrap tries to "switch"
>tabs, it wants to hide the initial tab and then show the new one. There
>is no "new" one here.
>
>The attached patch solves this problem by adding a CSS rule to
>guided_reports_start.tt with higher specificity than our global CSS
>making the relevant tab pane visible at all times.
>
>To test, apply the patch and go to Reports -> Use saved.
>
>- If necessary, create multiple SQL reports and assign them to different
>  report groups (Accounts, Acquisitions, Catalog, etc.).
>- Test that tab switching works:
>  - The tab should be style as "active" after you click it.
>  - The table of reports should be filtered to include only reports in
>    the relevant report group.
>
>Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt            | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 3a4ca5778c..7c6ab5eb0a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -78,6 +78,9 @@
>         font-weight: bold;
>         margin: 0;
>     }
>+    #tabs .tab-pane {
>+        display: block;
>+    }
> </style>
> [% Asset.css("css/reports.css") | $raw %]
> [% Asset.css("lib/d3c3/c3.min.css") | $raw %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37740: 170838 | 170871 | 170879