Attachment 170952 Details for Bug 37809 – Bug 37809: (follow-up) Remove wrong embed

[patch] Bug 37809: (follow-up) Remove wrong embed

Bug-37809-follow-up-Remove-wrong-embed.patch (text/plain), 1.11 KB, created by Tomás Cohen Arazi (tcohen) on 2024-09-02 17:28:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-09-02 17:28:17 UTC

Size: 1.11 KB

patch

obsolete

>From 8eab674e630ac267955f4d470fd557af2c64166d Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 2 Sep 2024 11:56:58 -0300
>Subject: [PATCH] Bug 37809: (follow-up) Remove wrong embed
>
>It seems to me like a copy and paste error coming from the holds
>endpoint.
>
>To test:
>1. Use a REST API tool like Postman to ask for some patron's checkouts
>2. Add x-koha-emebed: cancellation_requested
>=> FAIL: It explodes, cannot embed it
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: cancellation_requested no longer a valid option
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> api/v1/swagger/paths/patrons_checkouts.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/api/v1/swagger/paths/patrons_checkouts.yaml b/api/v1/swagger/paths/patrons_checkouts.yaml
>index bf44b12f23d..9b897a86478 100644
>--- a/api/v1/swagger/paths/patrons_checkouts.yaml
>+++ b/api/v1/swagger/paths/patrons_checkouts.yaml
>@@ -23,7 +23,6 @@
>         items:
>           type: string
>           enum:
>-            - cancellation_requested
>             - issuer
>             - item
>             - library
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 37809: 170949 | 170950 | 170952 | 170999