Attachment 170963 Details for Bug 35402 – Bug 35402: Fix regressions.t

[patch] Bug 35402: Fix regressions.t

Bug-35402-Fix-regressionst.patch (text/plain), 1.76 KB, created by Martin Renvoize (ashimema) on 2024-09-03 09:18:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-09-03 09:18:25 UTC

Size: 1.76 KB

patch

obsolete

>From 9594f0d2d3a7c6c9c9fcd66031326f83fddcea93 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 3 Sep 2024 11:03:17 +0200
>Subject: [PATCH] Bug 35402: Fix regressions.t
>
>The audio alert feature is not correctly designed and is problematic.
>It looks at the class name in the DOM, not when the element with this class name
>will be displayed to the end user
>
>So it's not possible to make it work for modals for instance, or if an element
>is built in JS then displayed
>
>This patch remove the modal code from the code, if there are no waiting
>holds. It is the behaviour that existed prior to the Bootstrap update.
>However it is kind of random behaviour, the song that is played when the
>librarian open the circ page is different if the user has waiting holds or not.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index d4f2b0261f7..c31e66bd869 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -963,7 +963,7 @@
>     </div> 
> </div> 
> 
>-[% #IF waiting_holds.count > 0 %]
>+[% IF waiting_holds.count > 0 %]
>     <div id="circ-warnwaitingholds-modal" class="modal audio-alert-action block">
>         <div class="modal-dialog">
>             <div class="modal-content">
>@@ -983,7 +983,7 @@
>             </div>
>         </div>
>     </div>
>-[% #END %]
>+[% END %]
> [% INCLUDE modals/cancel_booking.inc %]
> 
> [% MACRO jsinclude BLOCK %]
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 35402: 170651 | 170709 | 170710 | 170711 | 170712 | 170714 | 170715 | 170716 | 170717 | 170745 | 170768 | 170877 | 170905 | 170962 | 170963 | 171176