Attachment 170970 Details for Bug 37732 – Bug 37732: Fix 'Invalid PIN code' styling for 2FA

[patch] Bug 37732: Fix 'Invalid PIN code' styling for 2FA

Bug-37732-Fix-Invalid-PIN-code-styling-for-2FA.patch (text/plain), 1.97 KB, created by Jonathan Druart on 2024-09-03 10:03:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-09-03 10:03:27 UTC

Size: 1.97 KB

patch

obsolete

>From 3ddfe53ba80e120fedc1ecce8b3400fd9cd48735 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 3 Sep 2024 12:02:07 +0200
>Subject: [PATCH] Bug 37732: Fix 'Invalid PIN code' styling for 2FA
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/auth-two-factor.inc | 2 +-
> t/db_dependent/selenium/authentication_2fa.t                 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-two-factor.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-two-factor.inc
>index 3e6499ef10c..f7fe863c609 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-two-factor.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-two-factor.inc
>@@ -9,7 +9,7 @@
>             <p>Time based: Yes</p>
>         </div>
> 
>-        <div id="errors" class="dialog error" style="display: none;"></div>
>+        <div id="errors" class="alert alert-error" style="display: none;"></div>
> 
>         <fieldset class="rows">
>             <input type="hidden" id="secret32" name="secret32" value="[% secret32 | html %]" />
>diff --git a/t/db_dependent/selenium/authentication_2fa.t b/t/db_dependent/selenium/authentication_2fa.t
>index f390e357d47..9ef2e22cb0e 100755
>--- a/t/db_dependent/selenium/authentication_2fa.t
>+++ b/t/db_dependent/selenium/authentication_2fa.t
>@@ -87,7 +87,7 @@ SKIP: {
>         $driver->find_element('//*[@id="pin_code"]')->send_keys('wrong_code');
>         $driver->find_element('//*[@id="register-2FA"]')->click;
>         $s->wait_for_ajax;
>-        ok($driver->find_element('//div[@class="dialog error"][contains(text(), "Invalid PIN code")]'));
>+        ok($driver->find_element('//div[@class="alert alert-error"][contains(text(), "Invalid PIN code")]'));
>         is( $patron->get_from_storage->secret, undef, 'secret is not set in DB yet' );
> 
>         my $secret32 = $driver->find_element('//*[@id="secret32"]')->get_value();
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37732: 170913 | 170968 | 170969 | 170970 | 170978 | 170982