Attachment 170976 Details for Bug 37818 – Bug 37818: Remove 'XXX' from the installer code

[patch] Bug 37818: Remove 'XXX' from the installer code

Bug-37818-Remove-XXX-from-the-installer-code.patch (text/plain), 1006 bytes, created by David Nind on 2024-09-03 10:53:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-09-03 10:53:18 UTC

Size: 1006 bytes

patch

obsolete

>From 10c0124ced7eb9f5c31ee402638e4e60c591eb74 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 3 Sep 2024 11:43:49 +0200
>Subject: [PATCH] Bug 37818: Remove 'XXX' from the installer code
>
>We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068).
>
>We do no longer need this code.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/Installer.pm | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/Koha/Installer.pm b/Koha/Installer.pm
>index 48f8fc0f01..235eac3247 100644
>--- a/Koha/Installer.pm
>+++ b/Koha/Installer.pm
>@@ -55,10 +55,6 @@ sub TransformToNum {
>     # remove the 3 last . to have a Perl number
>     $version =~ s/(.*\..*)\.(.*)\.(.*)/$1$2$3/;
> 
>-    # three X's at the end indicate that you are testing patch with dbrev
>-    # change it into 999
>-    # prevents error on a < comparison between strings (should be: lt)
>-    $version =~ s/XXX$/999/;
>     return $version;
> }
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37818: 170964 | 170976 | 171129 | 171468