Attachment 170981 Details for Bug 37814 – Bug 37814: Fix incorrect use of __() in .tt files

[patch] Bug 37814: Fix incorrect use of __() in .tt files

Bug-37814-Fix-incorrect-use-of--in-tt-files.patch (text/plain), 4.15 KB, created by Owen Leonard on 2024-09-03 12:32:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-09-03 12:32:25 UTC

Size: 4.15 KB

patch

obsolete

>From ce0e1a7a62aea809de91888c258603394de7e619 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 3 Sep 2024 11:41:03 +0000
>Subject: [PATCH] Bug 37814: Fix incorrect use of __() in .tt files
>
>This patch corrects instances of the double-underscore function being
>used in .tt files where the single-underscore function should
>be used instead.
>
>To test, apply the patch and update a translation, e.g. fr-FR:
>
>  > gulp po:update --lang fr-FR
>
>- Open the corresponding .po file for the affected  strings, in this
>  case misc/translator/po/fr-FR-staff-prog.po
>- Confirm that the strings are now in the .po file for translation. You
>  should find these lines:
>
>  - koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt:
>    "Are you sure you want to unsubscribe %s from email alerts for %s?"
>  - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>    "Click to expand this section"
>
>- Check fr-FR-opac-bootstrap.po for this line:
>  - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt:
>    "Are you sure you want to unsubscribe %s from email alerts for %s?"
>
>Sponsored-by: Athens County Public Libraries
>---
> .../prog/en/modules/members/alert-subscriptions.tt            | 2 +-
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt   | 4 ++--
> .../bootstrap/en/modules/opac-alert-subscriptions.tt          | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt
>index 3be92e0f44..936511c59e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt
>@@ -109,7 +109,7 @@
>             $(".unsubscribe").submit(function(){
>                 var patron = $(this).data('patron');
>                 var title = $(this).data('title');
>-                return confirmDelete(__("Are you sure you want to unsubscribe %s from email alerts for %s?").format(patron, title));
>+                return confirmDelete(_("Are you sure you want to unsubscribe %s from email alerts for %s?").format(patron, title));
>             });
>         });
>     </script>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index ca4a298717..e271740a77 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1854,10 +1854,10 @@ legend.collapsed i.fa.fa-caret-down::before {
>         function togglePanel( node ){
>             var panel = node.nextAll();
>             if(panel.is(":visible")){
>-                node.addClass("collapsed").removeClass("expanded").attr("title", __("Click to expand this section") );
>+                node.addClass("collapsed").removeClass("expanded").attr("title", _("Click to expand this section") );
>                 panel.hide();
>             } else {
>-                node.addClass("expanded").removeClass("collapsed").attr("title", __("Click to collapse this section") );
>+                node.addClass("expanded").removeClass("collapsed").attr("title", _("Click to collapse this section") );
>                 panel.show();
>                 panel.find("input, select, textarea").eq(0).focus();
>             }
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt
>index d19b2fe6d3..e413ee30b4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt
>@@ -105,7 +105,7 @@
>         $(".unsubscribe").submit(function(){
>             var patron = $(this).data('patron');
>             var title = $(this).data('title');
>-            return confirmDelete(__("Are you sure you want to unsubscribe %s from email alerts for %s?").format(patron, title));
>+            return confirmDelete(_("Are you sure you want to unsubscribe %s from email alerts for %s?").format(patron, title));
>         });
>     });
> </script>
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37814: 170981 | 170989