Bugzilla – Attachment 171001 Details for
Bug 13342
Not logged in user can place a review/comment as a deleted patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13342: Perltidy
Bug-13342-Perltidy.patch (text/plain), 1.37 KB, created by
Hammat wele
on 2024-09-03 20:36:31 UTC
(
hide
)
Description:
Bug 13342: Perltidy
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2024-09-03 20:36:31 UTC
Size:
1.37 KB
patch
obsolete
>From d4b0a31a94eaec4329766af22e3fecd389201b6c Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Tue, 3 Sep 2024 20:34:16 +0000 >Subject: [PATCH] Bug 13342: Perltidy > >--- > opac/opac-review.pl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-review.pl b/opac/opac-review.pl >index f69740b2c2..0d85019ef6 100755 >--- a/opac/opac-review.pl >+++ b/opac/opac-review.pl >@@ -52,10 +52,10 @@ if( !$biblio ) { > } elsif( $reviewid ) { # edit existing one, check on creator > $savedreview = Koha::Reviews->search({ reviewid => $reviewid, borrowernumber => $borrowernumber })->next; > push @errors, { unauthorized => 1 } if !$savedreview; >-} else { # this check prevents adding multiple comments >- # FIXME biblionumber, borrowernumber should be a unique key of reviews >- $savedreview = Koha::Reviews->search({ biblionumber => $biblionumber, borrowernumber => $borrowernumber })->next; >- $review = $savedreview? $savedreview->review: $review; >+} else { # this check prevents adding multiple comments >+ # FIXME biblionumber, borrowernumber should be a unique key of reviews >+ $savedreview = Koha::Reviews->search( { biblionumber => $biblionumber, borrowernumber => $borrowernumber } )->next; >+ $review = $savedreview ? $savedreview->review : $review; > } > > if( $op =~ /^cud-/ && !@errors && defined $review ) { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13342
:
168286
|
171000
|
171001
|
171109
|
171110
|
171111
|
171118