Bugzilla – Attachment 171026 Details for
Bug 14250
Don't allow to generate discharges for patrons with fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14250: (follow-up) Refacto discharge messages display
Bug-14250-follow-up-Refacto-discharge-messages-dis.patch (text/plain), 2.84 KB, created by
Baptiste Wojtkowski (bwoj)
on 2024-09-04 13:09:04 UTC
(
hide
)
Description:
Bug 14250: (follow-up) Refacto discharge messages display
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2024-09-04 13:09:04 UTC
Size:
2.84 KB
patch
obsolete
>From 3f4190eae9960e38ff1edf024fd82c85acc7aed3 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 4 Sep 2024 14:45:44 +0200 >Subject: [PATCH] Bug 14250: (follow-up) Refacto discharge messages display > >The script that determines if one should display messages to the user, >informing him whether they are allowed or not to ask for a discharge is >quite hard to understand. > >For sake of readability, transforming the unless to an if since the >error behaviour was in the unless and the success in the else. >Changing to success behaviour in the if and failure in the else. >--- > .../bootstrap/en/modules/opac-discharge.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >index f657a4e..641395b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt >@@ -48,7 +48,13 @@ > <h2>What is a discharge?</h2> > <p>This document certifies that you have returned all borrowed items. It is sometimes asked during a file transfer from a school to another. The discharge is sent by us to your school. You will also find it available on your reader account.</p> > <p><strong>Warning</strong>: This request is only valid if you are in good standing with the library. Once the application is made, you can not borrow library materials.</p> >- [% UNLESS can_be_discharged %] >+ [% IF can_be_discharged %] >+ <form action="/cgi-bin/koha/opac-discharge.pl" method="post"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-request" /> >+ <button class="btn btn-primary" type="submit">Ask for a discharge</button> >+ </form> >+ [% ELSE %] > [% IF failure %] > <p> There was an error during the discharge process </p> > [% END %] >@@ -69,12 +75,6 @@ > [% END %] > </ul> > </div> >- [% ELSE %] >- <form action="/cgi-bin/koha/opac-discharge.pl" method="post"> >- [% INCLUDE 'csrf-token.inc' %] >- <input type="hidden" name="op" value="cud-request" /> >- <button class="btn btn-primary" type="submit">Ask for a discharge</button> >- </form> > [% END %] > > [% END %] >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14250
:
170136
|
170228
|
170581
|
170607
|
170662
|
170663
|
170664
|
170705
|
170706
|
170707
|
170708
|
171025
|
171026
|
171271
|
171272
|
171273
|
171274
|
171275
|
171276