Bugzilla – Attachment 171047 Details for
Bug 37840
Wrong status in the Intranet detail page when the item type is not for loan
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bug 37840 Fix item status in the Intranet detail page when the item has a item type not for loan
bug-37840-Fix-item-status-in-the-Intranet-detail-p.patch (text/plain), 2.60 KB, created by
Adolfo RodrÃguez Taboada
on 2024-09-05 07:23:45 UTC
(
hide
)
Description:
bug 37840 Fix item status in the Intranet detail page when the item has a item type not for loan
Filename:
MIME Type:
Creator:
Adolfo RodrÃguez Taboada
Created:
2024-09-05 07:23:45 UTC
Size:
2.60 KB
patch
obsolete
>From 3a5cd763f052dd6e5ffc2112777bd8661827588e Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Adolfo=20Rodr=C3=ADguez?= <adolfo.rodriguez@xercode.es> >Date: Thu, 5 Sep 2024 09:22:19 +0200 >Subject: [PATCH] bug 37840 Fix item status in the Intranet detail page when > the item has a item type not for loan > >When the item type is not for loan, the item status must be "Not for loan". Now in the Intranet status is Available while in the OPAC it's Not for loan. > >Test plan: >1 Define an item type as "Not for loan" >2 Add or edit an item so that its item type is "Not for loan" >3 Check that the status in the Intranet detail page shows Available while the OPAC detail page shows "Not for loan" >4 Apply patch, restart services >5 Check that the status is now "Not for loan" in both Intranet and OPAC >--- > .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 4a3d347a5b..099cfdd6fd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -485,7 +485,7 @@ > nodes += '<span class="dmg">%s</span>'.format(escape_str(damaged_lib)); > } > >- if ( row.not_for_loan_status || item_types_notforloan[row.item_type_id] ) { >+ if ( row.not_for_loan_status || item_types_notforloan.get(row.item_type_id) ) { > let not_for_loan_lib = av_not_for_loan.get(row.not_for_loan_status.toString()); > nodes += '<span class="notforloan">%s'.format(_("Not for loan")) + ( not_for_loan_lib ? '<span class="reason"> (%s)</span>'.format(escape_str(not_for_loan_lib)) : '' ) + '</span>'; > } >@@ -525,7 +525,7 @@ > } > [% END %] > >- if ( ! ( row.not_for_loan_status || item_types_notforloan[row.item_type_id] || row.checked_out_date || row.lost_status || row.withdrawn || row.damaged_status || row.transfer || row.first_hold || row.recall ) ) { >+ if ( ! ( row.not_for_loan_status || item_types_notforloan.get(row.item_type_id) || row.checked_out_date || row.lost_status || row.withdrawn || row.damaged_status || row.transfer || row.first_hold || row.recall ) ) { > nodes += ' <span>%s</span>'.format(_("Available")) > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37840
:
171047
|
171106
|
171570