Bugzilla – Attachment 171074 Details for
Bug 31161
OAI-PMH - Honour OpacHiddenItems system preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31161: Unit tests
Bug-31161-Unit-tests.patch (text/plain), 3.30 KB, created by
Nick Clemens (kidclamp)
on 2024-09-05 13:36:52 UTC
(
hide
)
Description:
Bug 31161: Unit tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-09-05 13:36:52 UTC
Size:
3.30 KB
patch
obsolete
>From 5abfa56700a9cae4014a6237d4a58ded1425a52c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 5 Sep 2024 13:35:50 +0000 >Subject: [PATCH] Bug 31161: Unit tests > >--- > t/db_dependent/OAI/Server.t | 75 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 74 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/OAI/Server.t b/t/db_dependent/OAI/Server.t >index 0b58f8aeafc..04f96915ca7 100755 >--- a/t/db_dependent/OAI/Server.t >+++ b/t/db_dependent/OAI/Server.t >@@ -21,7 +21,7 @@ use Modern::Perl; > use Test::Deep qw( cmp_deeply re ); > use Test::MockTime qw/set_fixed_time set_relative_time restore_time/; > >-use Test::More tests => 34; >+use Test::More tests => 35; > use DateTime; > use File::Basename; > use File::Spec; >@@ -515,6 +515,79 @@ subtest 'ListSets tests' => sub { > $schema->storage->txn_rollback; > }; > >+subtest 'Tests for OpacHiddenItems' => sub { >+ >+ plan tests => 4; >+ >+ t::lib::Mocks::mock_preference( 'OAI::PMH' => 1 ); >+ t::lib::Mocks::mock_preference( 'OAI-PMH:MaxCount' => 3 ); >+ t::lib::Mocks::mock_preference( >+ 'OAI-PMH:ConfFile' => File::Spec->rel2abs( dirname(__FILE__) ) . '/oaiconf_items.yaml' ); >+ $schema->storage->txn_begin; >+ my $builder = t::lib::TestBuilder->new; >+ my $item = $builder->build_sample_item(); >+ my $biblio = $item->biblio; >+ my $utc_datetime = dt_from_string( undef, undef, 'UTC' ); >+ my $utc_timestamp = $utc_datetime->ymd . 'T' . $utc_datetime->hms . 'Z'; >+ >+ my $get_items = { >+ verb => 'GetRecord', >+ metadataPrefix => 'marc21', >+ identifier => 'TEST:' . $item->biblionumber >+ }; >+ my $list_items = { >+ verb => 'ListRecords', >+ metadataPrefix => 'marc21', >+ from => $utc_timestamp >+ }; >+ my $expected = { >+ record => { >+ header => { >+ datestamp => $utc_timestamp, >+ identifier => 'TEST:' . $item->biblionumber >+ }, >+ metadata => >+ { record => XMLin( $biblio->metadata->record( { embed_items => 1, opac => 1 } )->as_xml_record() ) } >+ } >+ }; >+ my $expected_hidden = { >+ record => { >+ header => { >+ datestamp => $utc_timestamp, >+ identifier => 'TEST:' . $item->biblionumber, >+ status => 'deleted' >+ }, >+ } >+ }; >+ test_query( >+ 'GetRecord - biblio with a single item', >+ $get_items, >+ { GetRecord => $expected } >+ ); >+ test_query( >+ 'ListRecords - biblio with a single item', >+ $list_items, >+ { ListRecords => $expected } >+ ); >+ >+ my $opachiddenitems = " >+ itemnumber: ['" . $item->itemnumber . "']"; >+ t::lib::Mocks::mock_preference( 'OpacHiddenItems' => $opachiddenitems ); >+ >+ test_query( >+ 'GetRecord - biblio with a single item hidden by OpacHiddenItems returns as deleted', >+ $get_items, >+ { GetRecord => $expected_hidden } >+ ); >+ test_query( >+ 'ListRecords - biblio with a single item hidden by OpacHiddenItems returns as deleted', >+ $list_items, >+ { ListRecords => $expected_hidden } >+ ); >+ >+ $schema->storage->txn_rollback; >+}; >+ > subtest 'Tests for timestamp handling' => sub { > > plan tests => 28; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31161
:
170280
|
170300
|
170301
|
170353
|
170354
|
170632
|
170633
| 171074