Attachment 171075 Details for Bug 37843 – Bug 37843: Add warn to log errors when trying to connect to a remote SRU/z39.50 server

[patch] Bug 37843: Add warn to log errors when trying to connect to a remote SRU/z39.50 server

Bug-37843-Add-warn-to-log-errors-when-trying-to-co.patch (text/plain), 29.93 KB, created by Peter Vashchuk on 2024-09-05 14:07:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Vashchuk

Created: 2024-09-05 14:07:21 UTC

Size: 29.93 KB

patch

obsolete

>From 9b1d5828347a13c07c9ba79eedcd9891b574d6ed Mon Sep 17 00:00:00 2001
>From: Petro Vashchuk <stalkernoid@gmail.com>
>Date: Thu, 5 Sep 2024 17:02:43 +0300
>Subject: [PATCH] Bug 37843: Add warn to log errors when trying to connect to a
> remote SRU/z39.50 server
>
>Before this patch, when attempting to connect
>to a remote SRU/z39.50 server, errors such as
>incorrect URLs (404 error) or forgetting https
>(trying to access an https endpoint using http,
>resulting in a 400 error) were silently ignored.
>The system would simply return "nothing found"
>without logging any errors, making it difficult
>to troubleshoot connection issues. Also added
>error codes explanation
>(src: https://www.loc.gov/z3950/agency/contributions/1.html)
>---
> C4/Breeding.pm | 419 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 419 insertions(+)
>
>diff --git a/C4/Breeding.pm b/C4/Breeding.pm
>index 8dbaae9fff..5feff365ae 100644
>--- a/C4/Breeding.pm
>+++ b/C4/Breeding.pm
>@@ -32,6 +32,420 @@ use C4::Languages;
> use Koha::Database;
> use Koha::XSLT::Base;
> 
>+my %ERROR_CODE_MEANING = (
>+    # 2.1. General Messages
>+    1 => 'System unavailable - Permanent system error (ref. 1)',
>+    2 => 'System temporarily unavailable (ref. 2.)',
>+    100 => 'Unspecified error (ref. 100)',
>+    1001 => 'Do not display - origin should correct error or display "Protocol error (ref. 1001)"',
>+    1025 => 'Selected database {database} does not support {service} (ref. 1025)',
>+    1030 => 'Unknown message (ref. 1030)',
>+    1031 => 'Unknown message (ref. 1031)',
>+    1032 => 'Unknown message (ref. 1032)',
>+    1033 => 'Unknown message (ref. 1033)',
>+    1034 => 'Unknown message (ref. 1034)',
>+    1035 => 'Unknown message (ref. 1035)',
>+    1036 => 'Unknown message (ref. 1036)',
>+    1037 => 'Unknown message (ref. 1037)',
>+    1038 => 'Unknown message (ref. 1038)',
>+    1039 => 'Unknown message (ref. 1039)',
>+
>+    # 2.2. Init
>+    1010 => 'Unknown user identification (ref. 1010)',
>+    1011 => 'Unknown user identification or invalid password (ref. 1011)',
>+    1012 => 'No searches remaining (pre-purchased searches exhausted) (ref. 1012)',
>+    1013 => 'User identifier not valid for this operation ref. 1013)',
>+    1014 => 'Unknown user identification or invalid password (ref. 1014)',
>+    1015 => 'System temporarily unavailable (ref. 1015)',
>+    1016 => 'System temporarily unavailable (ref. 1016)',
>+    1017 => 'User identifier not valid for any available databases (ref. 1017)',
>+    1018 => 'System temporarily unavailable (ref. 1018)',
>+    1019 => 'System temporarily unavailable (ref. 1019)',
>+    1020 => 'System temporarily available (ref. 1020)',
>+    1021 => 'Access denied - Account has expired (ref. 1021)',
>+    1022 => 'Password expired - please supply new password (ref. 1022)',
>+    1023 => 'Password changed - please supply new password (ref. 1023)',
>+    1054 => 'Access denied - transaction incomplete (ref. 1054)',
>+    1055 => 'Access denied - transaction incomplete (ref. 1055)',
>+    # For diagnostics 1054 and 1055, it is recommended that the origin should take remedial action instead of displaying this message.
>+
>+    # 2.3. Search - General problems with the search statement
>+    3 => 'Unsupported search for this database (ref. 3)',
>+    11 => 'Search cannot be performed - Too long (too many characters in the search) (ref. 11)',
>+    101 => 'Security failure (ref. 101)',
>+    102 => 'Target protocol error (ref. 102) - (all targets should support search once init successful.)',
>+    107 => 'Origin should send a type 1 query. If the message is still received, origin should display "Target protocol error (ref. 107)".',
>+    108 => 'Cannot perform search - malformed query (ref. 108)',
>+
>+    # 2.4. Search - Messages relating to Database Selection
>+    3 => 'Unsupported search for this database (ref. 3)',
>+    23 => 'Specific combination of databases not supported (ref. 23)',
>+    29 => '{Database name} currently unavailable (ref. 29)',
>+    109 => '{Database name} currently unavailable (ref. 109)',
>+    111 => 'Cannot perform search - too many databases (ref. 111)',
>+    235 => 'Database does not exist (ref. 235)',
>+    236 => 'Access to {database name} denied (ref. 236)',
>+    1025 => 'Target Protocol error (ref. 1025)',
>+
>+    # 2.5. Search - Messages relating to Search Attributes
>+    113 => 'Cannot perform search as requested (ref. 113)',
>+    114 => 'Cannot perform search - {use attribute} not supported (ref. 114)',
>+    115 => 'Cannot perform search - structure of term not supported (ref. 115)',
>+    116 => 'Do not display - origin should correct error',
>+    117 => 'Cannot perform search - {relation attribute} not supported (ref. 117)',
>+    118 => 'Cannot perform search - {structure attribute} not supported (ref. 118)',
>+    119 => 'Cannot perform search - {position attribute} not supported (ref. 119)',
>+    120 => 'Cannot truncate search as requested (ref. 120)',
>+    121 => 'Cannot search by {attribute set / attribute} (ref. 121)',
>+    122 => 'Cannot perform search - {completeness attribute} not supported (ref. 122)',
>+    123 => 'Cannot search {attribute} with {attribute} as requested (ref. 123)',
>+    126 => 'Cannot perform search - incorrect construction (ref. 126)',
>+    245 => 'Cannot perform search as requested (ref. 245)',
>+    246 => 'Cannot perform search as requested (ref. 246)',
>+    247 => 'Cannot perform search as requested (ref. 247)',
>+    1024 => 'Cannot perform search as requested (ref. 1024)',
>+    1056 => 'Cannot perform search as requested (ref. 1056)',
>+
>+    # 2.6. Search - Messages relating to Search Term or Terms
>+    4 => 'Search cannot be performed - only contains common words that are not indexed (ref. 4)',
>+    5 => 'Search cannot be performed - Too many words or phrases in the search (ref. 5)',
>+    6 => 'Search cannot be performed - Too many words or phrases in the search (ref. 6)',
>+    7 => 'Search cannot be performed - Too many truncated words or phrases in the search (ref. 7)',
>+    8 => 'Search cannot be performed (ref. 8)',
>+    9 => 'Search cannot be performed - Truncated words are too short (ref. 9)',
>+    10 => 'Search cannot be performed - Invalid format of record number (ref. 10)',
>+    110 => 'Cannot perform search - {operator} not supported (ref. 110)',
>+    124 => 'Cannot search by {term} (ref. 124)',
>+    125 => 'Cannot search by {term} (ref. 125)',
>+    127 => '{Unnormalised value} cannot be processed (ref. 127)',
>+    1027 => 'Cannot perform search - incorrect construction (ref. 1027) - to be displayed if SQL created by user, else, display "SQL error (ref. 1027)"',
>+
>+    # 2.7. Search - Messages relating to Element Set Names and Element Specification
>+    24 => 'Origin should send a present request with an element set name of F or B and give message "Unable to specify record content as requested". If the message is still received, origin should display "Target protocol error (ref. 24)".',
>+    25 => 'Origin should send a present request with an element set name of F or B and give message "Unable to specify record content as requested". If the message is still received, origin should display "Target protocol error (ref. 25)".',
>+    26 => 'Origin should send a present request with an element set name of F or B and give message "Unable to specify record content as requested".',
>+
>+    # 2.8. Search - Messages relating to Results Set Names
>+    18 => 'Cannot search by {result set name} (ref. 18)',
>+    19 => 'Cannot search by more than one named results set (ref. 19)',
>+    20 => 'Cannot perform search - {operator} not valid with a results set. Valid search = {Results set name} AND {term} - Perform search? (ref. 20)',
>+    21 => 'Cannot create a results set with this name because it already exists - Delete existing results set? (ref. 21)',
>+    22 => 'Naming of search results not supported (ref. 22)',
>+    112 => 'Too many results sets already exist, select one or more from the following list to delete (ref. 112)',
>+    128 => '{Results set name} is an illegal name (ref. 128)',
>+
>+    # 2.9. Search - Messages relating to Piggyback Present
>+    # Messages relating to Individual Records
>+    14 => 'System error - cannot retrieve record or records (ref. 14)',
>+    15 => 'Cannot retrieve requested record - security failure (ref. 15)',
>+    16 => 'Oversized record, cannot be retrieved (ref. 16)',
>+    17 => 'Oversized record, cannot be retrieved (ref. 17)',
>+    103 => 'Record could not be retrieved - security failure (ref. 103)',
>+    104 => 'Record could not be retrieved - security failure (ref. 104)',
>+    1026 => 'Cannot retrieve record, currently locked (ref. 1026)',
>+    1028 => 'Cannot retrieve record - record deleted (ref. 1028)',
>+    # Messages relating to Record Syntax
>+    106 => 'Cannot retrieve record, record syntax not displayable (ref. 106)',
>+    227 => 'Cannot retrieve record, record syntax not displayable (ref. 227)',
>+    238 => 'Cannot retrieve record, record syntax not displayable (ref. 238)',
>+    239 => 'Cannot retrieve record, record syntax not displayable (ref. 239)',
>+    # Messages relating to Piggyback Present
>+    1005 => 'Do not display - perform a present request',
>+    1006 => 'Do not display - perform a present request',
>+
>+    # 2.10 Search - Messages relating to Proximity
>+    129 => 'Cannot do a proximity search of a results set (ref. 129)',
>+    130 => 'Do not display - origin should correct error',
>+    131 => 'Cannot do a proximity search using {relation type} (ref. 131)',
>+    132 => 'Cannot do a proximity search based on {known proximity unit} (ref. 132)',
>+    201 => 'Cannot do a proximity search with {attribute} combined with {attribute} (ref. 201)',
>+    202 => 'Cannot do a proximity search with a distance of {distance} and {known proximity unit} (ref. 202)',
>+    203 => 'Do not display - origin should retry without the ordered flag.',
>+    # Note that if the origin did not prompt for the proximity parameters then it should not present these messages to the user. In preference, the origin should attempt to construct a proximity search that will be accepted by the target or should revert to a boolean AND combination in the search.
>+
>+    # 2.11. Search - Messages relating to Search Results
>+    12 => 'Too many records retrieved (ref. 12)',
>+    31 => 'Search has not completed - No results available (ref. 31)',
>+    32 => 'Search has not completed - Partial results available, quality unknown (ref. 32)',
>+    33 => 'Search has not completed - Partial results available (ref. 33)',
>+
>+    # 2.12. Present - General messages
>+    13 => 'No more records to display ( ref. 13)',
>+    101 => 'Security failure (ref. 101)',
>+    102 => 'Target protocol error (ref. 102) - (all targets should support present once init successful.)',
>+    243 => 'Cannot retrieve more than one range of records at once (ref. 243)',
>+    244 => 'Cannot retrieve record with contents as specified (ref. 244)',
>+    1066 => 'Cannot retrieve record with contents as specified (ref. 1066)',
>+
>+    # 2.13. Present - Messages relating to Results Sets
>+    27 => 'Cannot retrieve records - results set was deleted (ref. 27)',
>+    28 => 'Cannot retrieve records - results set currently in use (ref. 28)',
>+    30 => 'Cannot retrieve records - results set not found (ref. 30)',
>+
>+    # 2.14. Present - Messages relating to Record Syntax
>+    106 => 'Cannot retrieve record, record syntax not displayable (ref. 106)',
>+    227 => 'Cannot retrieve record, record syntax not displayable (ref. 227)',
>+    238 => 'Cannot retrieve record, record syntax not displayable (ref. 238)',
>+    239 => 'Cannot retrieve record, record syntax not displayable (ref. 239)',
>+    1070 => 'User not authorized to receive this record in requested syntax',
>+
>+    # 2.15. Present - Messages relating to Segmentation
>+    217 => 'Oversized record or records, cannot guarantee quality of results (ref. 217)',
>+    242 => 'Cannot retrieve record - oversized (ref. 242)',
>+
>+    # 2.16. Present - Messages relating to Individual Records
>+    14 => 'System error - cannot retrieve record or records (ref. 14)',
>+    15 => 'Cannot retrieve requested record - security failure (ref. 15)',
>+    16 => 'Oversized record, cannot be retrieved (ref. 16)',
>+    17 => 'Oversized record, cannot be retrieved (ref. 17)',
>+    103 => 'Record could not be retrieved - security failure (ref. 103)',
>+    104 => 'Record could not be retrieved - security failure (ref. 104)',
>+    1026 => 'Cannot retrieve record, currently locked (ref. 1026)',
>+    1028 => 'Cannot retrieve record - record deleted (ref. 1028)',
>+
>+    # 2.17. Scan - General Messages
>+    101 => 'Security failure (ref. 101)',
>+    102 => 'Security failure (ref. 102)',
>+    205 => 'Cannot skip records when scanning, can only scan one by one (ref. 205)',
>+    206 => 'Cannot skip {step size} records when scanning (ref. 206)',
>+    228 => 'Do not display - origin should correct error',
>+    229 => 'Cannot scan by {term type} (ref. 229). Preferably, origin should retry scan using "general" type',
>+    232 => 'Cannot perform scan as requested (ref. 232) Preferably origin should perform multiple scans.',
>+    233 => 'Do not display - origin should resubmit scan without position in response.',
>+    234 => 'Cannot perform scan as requested (ref. 234) Preferably origin should perform multiple scans.',
>+    240 => 'Scan not completed - resources exhausted (ref. 240)',
>+    241 => 'Cannot scan any further - beginning or end reached (ref. 241)',
>+    1029 => 'Cannot perform scan as requested (ref. 1029) Preferably origin should perform multiple scans.',
>+
>+    # 2.18. Scan - Messages relating to Database Selection
>+    109 => '{Database name} currently unavailable (ref. 109)',
>+    111 => 'Cannot perform scan - too many databases (ref. 111)',
>+    235 => 'Database does not exist (ref. 235)',
>+    236 => 'Access to {database name} denied (ref. 236)',
>+    1025 => 'Scan not available for {database name} (ref. 1025)',
>+
>+    # 2.19. Scan - Messages relating to Scan attributes
>+    113 => 'Cannot perform scan as requested (ref. 113)',
>+    114 => 'Cannot perform scan - {use attribute} not supported (ref. 114)',
>+    115 => 'Cannot perform scan - structure of term not supported (ref. 115)',
>+    116 => 'Do not display - origin should correct error',
>+    117 => 'Cannot perform scan - {relation attribute} not supported (ref. 117)',
>+    118 => 'Cannot perform scan - {structure attribute} not supported (ref. 118)',
>+    119 => 'Cannot perform scan - {position attribute} not supported (ref. 119)',
>+    120 => 'Cannot truncate scan as requested (ref. 120)',
>+    121 => 'Cannot scan by {attribute set / attribute} (ref. 121)',
>+    122 => 'Cannot perform scan - {completeness attribute} not supported (ref. 122)',
>+    123 => 'Cannot scan {attribute} with {attribute} as requested (ref. 123)',
>+    126 => 'Cannot perform scan - incorrect construction (ref. 126)',
>+    1024 => 'Cannot perform scan as requested (ref. 1024)',
>+    1051 => 'Do not display - origin should correct error',
>+
>+    # 2.20. Explain
>+    102 => 'Security failure (ref. 102)',
>+    1007 => 'Message not displayed - origin should redirect explain request.',
>+
>+    # 2.21. Sort
>+    102 => 'Security failure (ref. 102)',
>+    207 => 'Cannot sort by {sequence} (ref. 207)',
>+    208 => 'Do not display - origin should correct error',
>+    209 => 'Can only sort the results from one database (ref. 209)',
>+    210 => 'Cannot sort results from {Database name} (ref. 210)',
>+    211 => 'Unable to sort - too many sort keys (ref. 211)',
>+    212 => 'Do not display - origin should correct error',
>+    213 => 'Do not display - origin should correct error',
>+    214 => 'Do not display - origin should correct error',
>+    215 => 'Do not display - origin should correct error',
>+    216 => 'Do not display - origin should correct error',
>+    230 => 'Too many records to sort (ref. 230)',
>+    231 => 'Unable to sort as requested (ref. 231)',
>+    237 => 'Do not display - origin should correct error',
>+
>+    # 3. Messages - Numeric Sequence
>+    1 => 'System unavailable - Permanent system error (ref. 1)',
>+    2 => 'System temporarily unavailable (ref. 2.)',
>+    3 => 'Unsupported search for this database (ref. 3)',
>+    4 => 'Search cannot be performed - only contains common words that are not indexed (ref. 4)',
>+    5 => 'Search cannot be performed - Too many words or phrases in the search (ref. 5)',
>+    6 => 'Search cannot be performed - Too many words or phrases in the search (ref. 6)',
>+    7 => 'Search cannot be performed - Too many truncated words or phrases in the search (ref. 7)',
>+    8 => 'Search cannot be performed (ref. 8)',
>+    9 => 'Search cannot be performed - Truncated words are too short (ref. 9)',
>+    10 => 'Search cannot be performed - Invalid format of record number (ref. 10)',
>+    11 => 'Search cannot be performed - Too long (too many characters in the search) (ref. 11)',
>+    12 => 'Too many records retrieved (ref. 12)',
>+    13 => 'No more records to display ( ref. 13)',
>+    14 => 'System error - cannot retrieve record or records (ref. 14)',
>+    15 => 'Cannot retrieve requested record - security failure (ref. 15)',
>+    16 => 'Oversized record, cannot be retrieved (ref. 16)',
>+    17 => 'Oversized record, cannot be retrieved (ref. 17)',
>+    18 => 'Cannot search by {result set name} (ref. 18)',
>+    19 => 'Cannot search by more than one named results set (ref. 19)',
>+    20 => 'Cannot perform search - {operator} not valid with a results set. Valid search = {Results set name} AND {term} - Perform search? (ref. 20)',
>+    21 => 'Cannot create a results set with this name because it already exists - Delete existing results set? (ref. 21)',
>+    22 => 'Naming of search results not supported (ref. 22)',
>+    23 => 'Specific combination of databases not supported (ref. 23)',
>+    24 => 'Origin should send a present request with an element set name of F or B and give message "Unable to specify record content as requested". If the message is still received, origin should display "Target protocol error (ref. 24)".',
>+    25 => 'Origin should send a present request with an element set name of F or B and give message "Unable to specify record content as requested". If the message is still received, origin should display "Target protocol error (ref. 25)".',
>+    26 => 'Origin should send a present request with an element set name of F or B and give message "Unable to specify record content as requested".',
>+    27 => 'Cannot retrieve records - results set was deleted (ref. 27)',
>+    28 => 'Cannot retrieve records - results set currently in use (ref. 28)',
>+    29 => '{Database name} currently unavailable (ref. 29)',
>+    30 => 'Cannot retrieve records - results set not found (ref. 30)',
>+    31 => 'Search has not completed - No results available (ref. 31)',
>+    32 => 'Search has not completed - Partial results available, quality unknown (ref. 32)',
>+    33 => 'Search has not completed - Partial results available (ref. 33)',
>+    100 => 'Unspecified error (ref. 100)',
>+    101 => 'Security failure (ref. 101)',
>+    102 => 'For Search and Present: Target protocol error (ref. 102)',
>+    # For other services: Security failure (ref. 102)
>+
>+    103 => 'Record could not be retrieved - security failure (ref. 103)',
>+    104 => 'Record could not be retrieved - security failure (ref. 104)',
>+    105 => 'Terminated as requested (ref. 105) (if user initiated the request)',
>+    106 => 'Cannot retrieve record, record syntax not displayable (ref. 106)',
>+    107 => 'Origin should send a type 1 query. If the message is still received, origin should display "Target protocol error (ref. 107)".',
>+    108 => 'Cannot perform search - malformed query (ref. 108)',
>+    109 => '{Database name} currently unavailable (ref. 109)',
>+    110 => 'Cannot perform search - {operator} not supported (ref. 110)',
>+    111 => 'Cannot perform search/scan - too many databases (ref. 111)',
>+    112 => 'Too many results sets already exist, select one or more from the following list to delete (ref. 112)',
>+    113 => 'Cannot perform search/scan as requested (ref. 113)',
>+    114 => 'Cannot perform search/scan - {use attribute} not supported (ref. 114)',
>+    115 => 'Cannot perform search/scan - structure of term not supported (ref. 115)',
>+    116 => 'Do not display - origin should correct error',
>+    117 => 'Cannot perform search/scan - {relation attribute} not supported (ref. 117)',
>+    118 => 'Cannot perform search/scan - {structure attribute} not supported (ref. 118)',
>+    119 => 'Cannot perform search/scan - {position attribute} not supported (ref. 119)',
>+    120 => 'Cannot truncate search/scan as requested (ref. 120)',
>+    121 => 'Cannot search/scan by {attribute set / attribute} (ref. 121)',
>+    122 => 'Cannot perform search/scan - {completeness attribute} not supported (ref. 122)',
>+    123 => 'Cannot search/scan {attribute} with {attribute} as requested (ref. 123)',
>+    124 => 'Cannot search by {term} (ref. 124)',
>+    125 => 'Cannot search by {term} (ref. 125)',
>+    126 => 'Cannot perform search/scan - incorrect construction (ref. 126)',
>+    127 => '{Unnormalised value} cannot be processed (ref. 127)',
>+    128 => '{Results set name} is an illegal name (ref. 128)',
>+    129 => 'Cannot do a proximity search of a results set (ref. 129)',
>+    130 => 'Do not display - origin should correct error',
>+    131 => 'Cannot do a proximity search using {relation type} (ref. 131)',
>+    132 => 'Cannot do a proximity search based on {known proximity unit} (ref. 132)',
>+    201 => 'Cannot do a proximity search with {attribute} combined with {attribute} (ref. 201)',
>+    202 => 'Cannot do a proximity search with a distance of {distance} and {known proximity unit} (ref. 202)',
>+    203 => 'Do not display - origin should retry without the ordered flag.',
>+    205 => 'Cannot skip records when scanning, can only scan one by one (ref. 205)',
>+    206 => 'Cannot skip {step size} records when scanning (ref. 206)',
>+    207 => 'Cannot sort by {sequence} (ref. 207)',
>+    208 => 'Do not display - origin should correct error',
>+    209 => 'Can only sort the results from one database (ref. 209)',
>+    210 => 'Cannot sort results from {Database name} (ref. 210)',
>+    211 => 'Unable to sort - too many sort keys (ref. 211)',
>+    212 => 'Do not display - origin should correct error',
>+    213 => 'Do not display - origin should correct error',
>+    214 => 'Do not display - origin should correct error',
>+    215 => 'Do not display - origin should correct error',
>+    216 => 'Do not display - origin should correct error',
>+    217 => 'Oversized record or records, cannot guarantee quality of results (ref. 217)',
>+    218 => 'Do not display - client should assign a different name',
>+    219 => 'Cannot perform {extended service} cannot find task reference number (ref. 219)',
>+    220 => 'Cannot perform {extended service}, quota exceeded (ref. 220)',
>+    221 => 'Cannot perform {extended service}, service not supported (ref. 221)',
>+    222 => 'Cannot perform {extended service}, not authorized (ref. 222)',
>+    223 => 'Cannot change or delete {extended service}, not authorized (ref. 223)',
>+    224 => 'Cannot perform {extended service} interactively (ref. 224)',
>+    225 => 'Cannot perform {extended service} interactively (ref. 225)',
>+    226 => 'Cannot perform this {extended service} interactively (ref. 226)',
>+    227 => 'Cannot retrieve record, record syntax not displayable (ref. 227)',
>+    228 => 'Do not display - origin should correct error',
>+    229 => 'Cannot scan by {term type} (ref. 229). Preferably, origin should retry scan using "general" type',
>+    230 => 'Too many records to sort (ref. 230)',
>+    231 => 'Unable to sort as requested (ref. 231)',
>+    232 => 'Cannot perform scan as requested (ref. 232) Preferably origin should perform multiple scans.',
>+    233 => 'Do not display - origin should resubmit scan without position in response.',
>+    234 => 'Cannot perform scan as requested (ref. 234) Preferably origin should perform multiple scans.',
>+    235 => 'Database does not exist (ref. 235)',
>+    236 => 'Access to {database name} denied (ref. 236)',
>+    237 => 'Do not display - origin should correct error',
>+    238 => 'Cannot retrieve record, record syntax not displayable (ref. 238)',
>+    239 => 'Cannot retrieve record, record syntax not displayable (ref. 239)',
>+    240 => 'Scan not completed - resources exhausted (ref. 240)',
>+    241 => 'Cannot scan any further - beginning or end reached (ref. 241)',
>+    242 => 'Cannot retrieve record - oversized (ref. 242)',
>+    243 => 'Cannot retrieve more than one range of records at once (ref. 243)',
>+    244 => 'Cannot retrieve record with contents as specified (ref. 244)',
>+    245 => 'Cannot perform search as requested (ref. 245)',
>+    246 => 'Cannot perform search as requested (ref. 246)',
>+    247 => 'Cannot perform search as requested (ref. 247)',
>+    1001 => 'Do not display - origin should correct error or display "Protocol error (ref. 1001)"',
>+    1002 => 'Cannot accept Item Order request as formatted (ref. 1002)',
>+    1003 => 'Cannot accept Item Order request as formatted (ref. 1003)',
>+    1004 => 'Cannot perform {extended service} - security procedures not met (ref. 1004)',
>+    1005 => 'Do not display - perform a present request',
>+    1006 => 'Do not display - perform a present request',
>+    1007 => 'Message not displayed - origin should redirect explain request.',
>+    1008 => 'Cannot perform {extended service} - missing data (ref. 1008)',
>+    1009 => 'Cannot accept Item Order request as formatted (ref. 1009)',
>+    1010 => 'Unknown user identification (ref. 1010)',
>+    1011 => 'Unknown user identification or invalid password (ref. 1011)',
>+    1012 => 'No searches remaining (pre-purchased searches exhausted) (ref. 1012)',
>+    1013 => 'User identifier not valid for this operation ref. 1013)',
>+    1014 => 'Unknown user identification or invalid password (ref. 1014)',
>+    1015 => 'System temporarily unavailable (ref. 1015)',
>+    1016 => 'System temporarily unavailable (ref. 1016)',
>+    1017 => 'User identifier not valid for any available databases (ref. 1017)',
>+    1018 => 'System temporarily unavailable (ref. 1018)',
>+    1019 => 'System temporarily unavailable (ref. 1019)',
>+    1020 => 'System temporarily available (ref. 1020)',
>+    1021 => 'Access denied - Account has expired (ref. 1021)',
>+    1022 => 'Password expired - please supply new password (ref. 1022)',
>+    1023 => 'Password changed - please supply new password (ref. 1023)',
>+    1024 => 'Cannot perform search as requested (ref. 1024)',
>+    1025 => 'For Search and Present - Target Protocol error (ref. 1025)',
>+    # For other services : Selected database {database} does not support {service} (ref. 1025)
>+
>+    1026 => 'Cannot retrieve record, currently locked (ref. 1026)',
>+    1027 => 'Cannot perform search - incorrect construction (ref. 1027) - to be displayed if SQL created by user, else, display "SQL error (ref. 1027)"',
>+    1028 => 'Cannot retrieve record - record deleted (ref. 1028)',
>+    1029 => 'Cannot perform scan as requested (ref. 1029) Preferably origin should perform multiple scans.',
>+    1030 => 'Unknown message (ref. 1030)',
>+    1031 => 'Unknown message (ref. 1031)',
>+    1032 => 'Unknown message (ref. 1032)',
>+    1033 => 'Unknown message (ref. 1033)',
>+    1034 => 'Unknown message (ref. 1034)',
>+    1035 => 'Unknown message (ref. 1035)',
>+    1036 => 'Unknown message (ref. 1036)',
>+    1037 => 'Unknown message (ref. 1037)',
>+    1038 => 'Unknown message (ref. 1038)',
>+    1039 => 'Unknown message (ref. 1039)',
>+    1040 => 'Do not display - origin should correct error',
>+    1041 => 'Cannot perform {extended service} - invalid transaction data (ref. 1041)',
>+    1042 => 'Cannot perform {extended service} - invalid transaction data (ref. 1042)',
>+    1043 => 'Do not display - origin should correct error',
>+    1044 => 'Do not display - origin should correct error',
>+    1045 => 'Cannot perform {extended service} - {schema} schema unknown (ref. 1045)',
>+    1046 => 'Do not display - origin should break into two or more packages. If only one record in package, treat as if message 1052.',
>+    1047 => 'Do not display - origin should correct error',
>+    1048 => 'Do not display - origin should break into two or more packages. If only one record in package, treat as if message 1052.',
>+    1049 => 'Not displayed (but may be logged). Origin should search the task package or the database directly.',
>+    1050 => 'Do not display - origin should break into two or more packages. If only one record in package, treat as if message 1052.',
>+    1051 => 'Do not display - origin should correct error',
>+    1052 => 'Cannot update this record - too large (ref. 1052)',
>+    1053 => 'Not displayed (but may be logged). Origin should search the task package or the database directly.',
>+    1054 => 'Access denied - transaction incomplete (ref. 1054)',
>+    1055 => 'Access denied - transaction incomplete (ref. 1055)',
>+    1056 => 'Cannot perform search as requested (ref. 1056)',
>+    1057 => 'Cannot perform {extended service} as requested (ref. 1057)',
>+    1058 => 'Results may contain duplicates (ref. 1058)',
>+    1059 => 'Results may contain duplicates (ref. 1059)',
>+    1060 => 'Results may contain duplicates (ref. 1060)',
>+    1061 => 'Results may contain duplicates (ref. 1061)',
>+    1062 => 'Results may contain duplicates (ref. 1062)',
>+    1063 => 'Results may contain duplicates (ref. 1063)',
>+    1064 => 'Results may contain duplicates (ref. 1064)',
>+    1065 => 'Results may contain duplicates (ref. 1065)',
>+    1066 => 'Cannot retrieve record with contents as specified (ref. 1066)',
>+    # 1070 => 'User not authorized to receive this record in requested syntax',
>+);
>+
> our (@ISA, @EXPORT_OK);
> BEGIN {
>     require Exporter;
>@@ -175,6 +589,11 @@ sub Z3950Search {
>                 if ($error =~ m/^(10000|10007)$/ ) {
>                     push(@errconn, { server => $servers[$k]->{host}, error => $error } );
>                 }
>+                else {
>+                    # for example when we have 'http 400' or '404' or other errors - at least we should log those!
>+                    #  16  Record exceeds Preferred-message-size   Oversized record, cannot be retrieved (ref. 16)
>+                    warn "Error when doing search from remote: " . ($ERROR_CODE_MEANING{$error} || $error);
>+                }
>             }
>             else {
>                 my $numresults = $oResult[$k]->size();
>-- 
>2.46.0

Actions: View | Diff | Splinter Review

Attachments on bug 37843: 171075