Attachment 171115 Details for Bug 37854 – Bug 37854: Add fieldset.rows so that Javascript works

[patch] Bug 37854: Add fieldset.rows so that Javascript works

Bug-37854-Add-fieldsetrows-so-that-Javascript-work.patch (text/plain), 2.23 KB, created by David Cook on 2024-09-06 01:50:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2024-09-06 01:50:35 UTC

Size: 2.23 KB

patch

obsolete

>From 8854777d4081a39fb4ba0d6fe8e9a5977003670a Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Fri, 6 Sep 2024 01:45:27 +0000
>Subject: [PATCH] Bug 37854: Add fieldset.rows so that Javascript works
>
>This change adds a fieldset.rows that the Javascript produced
>by C4/Barcodes/ValueBuilder.pm will work here too like it
>does for /cgi-bin/koha/cataloguing/additem.pl and
>/cgi-bin/koha/acqui/neworderempty.pl
>
>The fieldset.rows element ruins the styling, so we add some context
>specific styling to the styling is preserved.
>
>Test plan:
>0. Apply the patch
>1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001"
>2. Create a vendor
>3. Create a backet with "Create items when" set to "receiving an order"
>4. Add an order (any order)
>5. Close the basket
>6. Receive the shipment
>7. Click in the barcode field
>8. Note that you get a barcode like CPL24090001 and not undefined24090001
>---
> .../intranet-tmpl/prog/en/modules/acqui/orderreceive.tt     | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 9daac07657..fd280aa2c3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -71,6 +71,10 @@
>             content: none;
>         }
> 
>+        #top_itemfieldset {
>+            padding: 0px;
>+        }
>+
>     </style>
> </head>
> 
>@@ -204,6 +208,7 @@
>                                     </table>
>                                 </div>
>                             </div>
>+                            <fieldset class="rows" id="top_itemfieldset">
>                             <div id="items-panel" class="page-section">
>                                 <div id="acq-create-receiving">
>                                     <div id="items_list" style="display: none">
>@@ -275,6 +280,7 @@
>                                     </div>
>                                 </div>
>                             </div>
>+                            </fieldset>
>                         </div>
>                         <div class="col-md-12 col-lg-6">
>                             <div id="accounting-panel" class="page-section">
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37854: 171115 | 171116 | 171234 | 171235