Bugzilla – Attachment 171118 Details for
Bug 13342
Not logged in user can place a review/comment as a deleted patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13342: Not logged user can place a review/comment
Bug-13342-Not-logged-user-can-place-a-reviewcommen.patch (text/plain), 1.52 KB, created by
Marcel de Rooy
on 2024-09-06 07:21:10 UTC
(
hide
)
Description:
Bug 13342: Not logged user can place a review/comment
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-09-06 07:21:10 UTC
Size:
1.52 KB
patch
obsolete
>From ec7abf472f6b7cd174e74e5d2d5d44aca8e25259 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Tue, 3 Sep 2024 20:31:21 +0000 >Subject: [PATCH] Bug 13342: Not logged user can place a review/comment >Content-Type: text/plain; charset=utf-8 > >We are able to comment a notice even when no user is connected > >To test > >1. Log in to OPAC. >2. Find a Biblio and open the comments tab. >3. Open another tab/window, and log out from the account. >4. Return to the first tab. >5. Click "Post your comments on this title." > --> We are able to post a comment >6. Apply the patch >7. Repeat step 1, 2, 3, 4, 5 > --> You should be redirected to the login page. > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Bug 13342: Tidy > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-review.pl | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-review.pl b/opac/opac-review.pl >index e948e1cf16..814cd60f75 100755 >--- a/opac/opac-review.pl >+++ b/opac/opac-review.pl >@@ -36,10 +36,9 @@ my $op = $query->param('op') // q{}; > > my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > { >- template_name => "opac-review.tt", >- query => $query, >- type => "opac", >- authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), >+ template_name => "opac-review.tt", >+ query => $query, >+ type => "opac", > } > ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13342
:
168286
|
171000
|
171001
|
171109
|
171110
|
171111
| 171118